GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: remove npm install from acorn update by marco-ippolito · Pull Request #50473 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Oct 30, 2023

Copy link
Copy Markdown
Member

Refs: nodejs/security-wg#1037

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
marco-ippolito added 2 commits October 30, 2023 11:12
@marco-ippolito
tools: improve update acorn-walk script
1ad72f3
@marco-ippolito
tools: download acorn without npm
997d04b
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 30, 2023
@marco-ippolito
fix: use npm pack instead of curl
ad36f34
lpinca
lpinca approved these changes Oct 30, 2023
View reviewed changes
Comment thread tools/dep_updaters/update-acorn-walk.sh

NEW_VERSION=$("$NODE" "$NPM" view acorn-walk dist-tags.latest)
CURRENT_VERSION=$("$NODE" -p "require('./deps/acorn/acorn-walk/package.json').version")
CURRENT_VERSION=$("$NODE" "$NPM" --prefix './deps/acorn/acorn-walk/' pkg get version)

@lpinca lpinca Oct 30, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this? Using npm seems overkill.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@marco-ippolito marco-ippolito Oct 31, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a particular reason, it feels more clean since its npm pkg get does exactly that

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@lpinca lpinca Oct 31, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the original one and it's faster.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tools/dep_updaters/update-acorn.sh

NEW_VERSION=$("$NODE" "$NPM" view acorn dist-tags.latest)
CURRENT_VERSION=$("$NODE" -p "require('./deps/acorn/acorn/package.json').version")
CURRENT_VERSION=$("$NODE" "$NPM" --prefix './deps/acorn/acorn/' pkg get version)

@lpinca lpinca Oct 30, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marco-ippolito
fix: forgot to update file
46cfd76
@marco-ippolito marco-ippolito mentioned this pull request Nov 1, 2023
deps: update acorn-walk to 8.3.1 #50457
Closed
ShogunPanda
ShogunPanda approved these changes Nov 1, 2023
View reviewed changes
@marco-ippolito marco-ippolito added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 2a1bd66 into nodejs:main Nov 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 2a1bd66
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Nov 11, 2023
@marco-ippolito @targos
tools: improve update acorn-walk script
27e3f09 
PR-URL: #50473
Refs: nodejs/security-wg#1037
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@marco-ippolito @targos
tools: improve update acorn-walk script
aa8feea 
PR-URL: #50473
Refs: nodejs/security-wg#1037
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@marco-ippolito @UlisesGascon
tools: improve update acorn-walk script
631d710 
PR-URL: #50473
Refs: nodejs/security-wg#1037
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@ShogunPanda ShogunPanda ShogunPanda approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@marco-ippolito @nodejs-github-bot @ShogunPanda @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.