GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: fix Writable.destroy performance regression by Trott · Pull Request #50478 · nodejs/node

Conversation

@Trott

@Trott Trott commented Oct 30, 2023

Copy link
Copy Markdown
Member

PR-URL: #50409

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 30, 2023
@Trott
Trott marked this pull request as ready for review October 30, 2023 20:11
@Trott
Trott marked this pull request as draft October 30, 2023 20:11
@Trott

Trott commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

This PR is here just to run the Coverage Linux (without intl) job using the same change in #50409 but against the current main branch to see if that succeeds where that PR has failed 4 times in a row.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott marked this pull request as ready for review October 30, 2023 23:14
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2023
@Trott Trott mentioned this pull request Oct 30, 2023
stream: fix Writable.destroy performance regression #50409
Closed
@Trott
Trott requested review from benjamingr, jasnell, mcollina and rluvaton October 30, 2023 23:17
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 30, 2023
@github-actions

github-actions Bot commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
bricss, ronag, H4ad, KhafraDev, and mcollina reacted with thumbs up emoji
All reactions
  • 👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2023
H4ad
H4ad approved these changes Oct 31, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55336/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55357/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55362/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 31, 2023
@Trott

Trott commented Oct 31, 2023

Copy link
Copy Markdown
Member Author

This is ready to land but needs one more approval.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ronag
ronag previously approved these changes Oct 31, 2023
View reviewed changes
@ronag ronag added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 31, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 31, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50478
✔  Done loading data for nodejs/node/pull/50478
----------------------------------- PR info ------------------------------------
Title      stream: fix Writable.destroy performance regression (#50478)
Author     Rich Trott  (@Trott)
Branch     Trott:test-pr -> nodejs:main
Labels     fast-track, author ready, needs-ci
Commits    1
 - stream: fix Writable.destroy performance regression
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/50478
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Robert Nagy 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50478
Reviewed-By: Vinícius Lourenço Claro Cardoso 
Reviewed-By: Robert Nagy 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 30 Oct 2023 20:10:40 GMT
   ✔  Approvals: 2
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50478#pullrequestreview-1705323018
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/50478#pullrequestreview-1707190813
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-10-31T18:59:52Z: https://ci.nodejs.org/job/node-test-pull-request/55362/
- Querying data for job/node-test-pull-request/55362/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6712160359
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott dismissed ronag’s stale review October 31, 2023 21:35

I'm going to dismiss this one because it's the commit author.

aduh95
aduh95 approved these changes Oct 31, 2023
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss a bit of context on how this is perf related, but the change looks fine to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ronag @Trott
stream: fix Writable.destroy performance regression
c4decd7 
Ref: nodejs#50409
PR-URL: nodejs#50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Trott
Trott force-pushed the test-pr branch from 4ff079a to c4decd7 Compare October 31, 2023 21:45
@Trott
Trott merged commit c4decd7 into nodejs:main Oct 31, 2023
@Trott

Trott commented Oct 31, 2023

Copy link
Copy Markdown
Member Author

Landed in c4decd7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the test-pr branch October 31, 2023 21:45
@github-actions github-actions Bot mentioned this pull request Nov 1, 2023
CI Reliability 2023-11-01 nodejs/reliability#704
Open
24 tasks
This was referenced Nov 2, 2023
CI Reliability 2023-11-02 nodejs/reliability#705
Open
CI Reliability 2023-11-03 nodejs/reliability#706
Open
CI Reliability 2023-11-04 nodejs/reliability#707
Open
CI Reliability 2023-11-05 nodejs/reliability#708
Open
CI Reliability 2023-11-06 nodejs/reliability#709
Open
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag @targos
stream: fix Writable.destroy performance regression
3674ad5 
Ref: #50409
PR-URL: #50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@ronag @targos
stream: fix Writable.destroy performance regression
360f5d9 
Ref: #50409
PR-URL: #50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@ronag @UlisesGascon
stream: fix Writable.destroy performance regression
6012e3e 
Ref: #50409
PR-URL: #50478
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@H4ad H4ad H4ad approved these changes
@aduh95 aduh95 aduh95 approved these changes
@ronag ronag ronag left review comments
@mcollina mcollina Awaiting requested review from mcollina
@jasnell jasnell Awaiting requested review from jasnell
@benjamingr benjamingr Awaiting requested review from benjamingr
@rluvaton rluvaton Awaiting requested review from rluvaton

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @nodejs-github-bot @ronag @H4ad @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.