GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: V8: cherry-pick 70caf337c3f6 by kxxt · Pull Request #50506 · nodejs/node

Conversation

@kxxt

@kxxt kxxt commented Nov 1, 2023

Copy link
Copy Markdown
Member

Original commit message:

[riscv64] Fix the StaticStackFrameSize

 Update the size to kTierupBudgetOffset.

Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
Reviewed-by: ji qiu <[email protected]>
Commit-Queue: Yahan Lu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33

Fixes #50503

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@kxxt
deps: V8: cherry-pick 70caf337c3f6
b989f80 
Original commit message:

    [riscv64] Fix the StaticStackFrameSize

     Update the size to kTierupBudgetOffset.

    Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
    Reviewed-by: ji qiu <[email protected]>
    Commit-Queue: Yahan Lu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v18.x v8 engine Issues and PRs related to the V8 dependency. labels Nov 1, 2023
richardlau
richardlau approved these changes Nov 1, 2023
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 1, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55388/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5642/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5642/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Nov 1, 2023
@kxxt
addpatch: nodejs-lts-hydrogen
71898ee 
Backport `[riscv64] Fix the StaticStackFrameSize` to fix vite.

- Upstream issue: nodejs/node#50503
- Upstream PR: nodejs/node#50506
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5642/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kxxt kxxt mentioned this pull request Nov 1, 2023
addpatch: nodejs-lts-hydrogen felixonmars/archriscv-packages#3206
Merged
@targos targos added the riscv64 Issues and PRs related to the 64-bit RISC-V architecture. label Nov 1, 2023
targos
targos approved these changes Nov 1, 2023
View reviewed changes
@richardlau

richardlau commented Nov 1, 2023

Copy link
Copy Markdown
Member

cc @nodejs/platform-riscv64
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55395/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55404/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gengjiawen
gengjiawen approved these changes Nov 2, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55416/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Nov 2, 2023
@kxxt @felixonmars
addpatch: nodejs-lts-hydrogen
32d1b2e 
Backport `[riscv64] Fix the StaticStackFrameSize` to fix vite.

- Upstream issue: nodejs/node#50503
- Upstream PR: nodejs/node#50506
@richardlau

richardlau commented Nov 2, 2023

Copy link
Copy Markdown
Member

I've opened a build issue for the Windows failure: nodejs/build#3554
kxxt reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55425/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55426/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 3, 2023
CI Reliability 2023-11-03 nodejs/reliability#706
Open
CI Reliability 2023-11-04 nodejs/reliability#707
Open
CI Reliability 2023-11-05 nodejs/reliability#708
Open
CI Reliability 2023-11-06 nodejs/reliability#709
Open
This was referenced Nov 7, 2023
CI Reliability 2023-11-07 nodejs/reliability#710
Open
CI Reliability 2023-11-08 nodejs/reliability#711
Open
CI Reliability 2023-11-09 nodejs/reliability#712
Open
@kxxt

kxxt commented Nov 9, 2023

Copy link
Copy Markdown
Member Author

Hi, any progress here? It's been a week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Nov 9, 2023

Copy link
Copy Markdown
Member

Don't worry. I'm preparing the next v18.x release and will merge this in due time.
kxxt reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Nov 27, 2023

Copy link
Copy Markdown
Member

Landed in 7af5427
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Nov 27, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
@kxxt @targos
deps: V8: cherry-pick 70caf337c3f6
7af5427 
Original commit message:

    [riscv64] Fix the StaticStackFrameSize

     Update the size to kTierupBudgetOffset.

    Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
    Reviewed-by: ji qiu <[email protected]>
    Commit-Queue: Yahan Lu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33
PR-URL: #50506
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: V8: cherry-pick 70caf337c3f6
383a856 
Original commit message:

    [riscv64] Fix the StaticStackFrameSize

     Update the size to kTierupBudgetOffset.

    Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
    Reviewed-by: ji qiu <[email protected]>
    Commit-Queue: Yahan Lu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33
PR-URL: nodejs/node#50506
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: V8: cherry-pick 70caf337c3f6
2380ce6 
Original commit message:

    [riscv64] Fix the StaticStackFrameSize

     Update the size to kTierupBudgetOffset.

    Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
    Reviewed-by: ji qiu <[email protected]>
    Commit-Queue: Yahan Lu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33
PR-URL: nodejs/node#50506
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. riscv64 Issues and PRs related to the 64-bit RISC-V architecture. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kxxt @nodejs-github-bot @richardlau @targos @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.