GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove unused file by jsumners · Pull Request #50528 · nodejs/node

Conversation

@jsumners

@jsumners jsumners commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

This removes a source file that got re-added via a rebase. It seems somewhere around change set
178dff2 entry_point.c was removed, and rebase
0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to Node-API. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 2, 2023
@jsumners
jsumners force-pushed the remove-unused-file branch from fb62571 to 907393e Compare November 2, 2023 13:10
@jsumners jsumners changed the title chore: remove unused file src: remove unused file Nov 2, 2023
Uzlopak
Uzlopak approved these changes Nov 2, 2023
View reviewed changes

@Uzlopak Uzlopak left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes Nov 2, 2023
View reviewed changes
legendecas
legendecas approved these changes Nov 2, 2023
View reviewed changes
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 3, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55432/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vmoroz
vmoroz approved these changes Nov 3, 2023
View reviewed changes

@vmoroz vmoroz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tniessen
tniessen approved these changes Nov 3, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix before merging: the subsystem in the commit message is wrong. It should likely be test, not src.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jsumners jsumners changed the title src: remove unused file test: remove unused file Nov 3, 2023
@jsumners
test: remove unused file
69ae652 
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
nodejs@178dff2
`entry_point.c` was removed, and rebase
nodejs@0b6e16f
added it back. The review of nodejs#48740
overlooked this and the file got re-committed.
@jsumners
jsumners force-pushed the remove-unused-file branch from 907393e to 69ae652 Compare November 3, 2023 16:50
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 3, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55437/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55535/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas

legendecas commented Nov 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://ci.nodejs.org/job/node-test-commit-aix/48935/ was failing for node-api.test_worker_buffer_callback.test-free-called but I don't think it is related to this PR. Reliability report: https://github.com/nodejs/reliability/issues?q=is%3Aissue+is%3Aopen+test_worker_buffer_callback
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 10, 2023
legendecas
legendecas approved these changes Nov 10, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 43f5b22 into nodejs:main Nov 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in 43f5b22
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jsumners
jsumners deleted the remove-unused-file branch November 10, 2023 17:23
targos pushed a commit that referenced this pull request Nov 11, 2023
@jsumners @targos
test: remove unused file
74a7d47 
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
178dff2
`entry_point.c` was removed, and rebase
0b6e16f
added it back. The review of #48740
overlooked this and the file got re-committed.

PR-URL: #50528
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@jsumners @targos
test: remove unused file
2fdcf5c 
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
178dff2
`entry_point.c` was removed, and rebase
0b6e16f
added it back. The review of #48740
overlooked this and the file got re-committed.

PR-URL: #50528
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@jsumners @UlisesGascon
test: remove unused file
8a5f36f 
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
178dff2
`entry_point.c` was removed, and rebase
0b6e16f
added it back. The review of #48740
overlooked this and the file got re-committed.

PR-URL: #50528
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoroz vmoroz vmoroz approved these changes
@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@Uzlopak Uzlopak Uzlopak approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. node-api Issues and PRs related to Node-API. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@jsumners @nodejs-github-bot @legendecas @vmoroz @lpinca @tniessen @Uzlopak
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.