GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: correct attribution in v20.6.0 changelog by JakobJingleheimer · Pull Request #50564 · nodejs/node

Conversation

@JakobJingleheimer

@JakobJingleheimer JakobJingleheimer commented Nov 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Not sure what happened when these were generated, but the original PR that introduced the feature was omitted and co-authorship on both PRs was lost.

Related: nodejs/nodejs.org#6095

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JakobJingleheimer
doc: correct attribution in v20.6.0 changelog
511f21b
@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Nov 5, 2023
@JakobJingleheimer JakobJingleheimer mentioned this pull request Nov 5, 2023
meta: correct attribution in v20.6.0 release notes nodejs/nodejs.org#6095
Merged
@JakobJingleheimer JakobJingleheimer added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 5, 2023
@github-actions

github-actions Bot commented Nov 5, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve.
marco-ippolito and ovflowd reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
UlisesGascon
UlisesGascon approved these changes Nov 5, 2023
View reviewed changes

@UlisesGascon UlisesGascon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why/how I introduced this bug, but thanks for the fix 🙂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JakobJingleheimer reacted with laugh emoji
All reactions
  • 😄 1 reaction
@JakobJingleheimer

JakobJingleheimer commented Nov 5, 2023

Copy link
Copy Markdown
Member Author

Cheers!

Could you 👍 the fast-track 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Nov 6, 2023
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 6, 2023
@JakobJingleheimer JakobJingleheimer added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Nov 6, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50564
✔  Done loading data for nodejs/node/pull/50564
----------------------------------- PR info ------------------------------------
Title      doc: correct attribution in v20.6.0 changelog (#50564)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     JakobJingleheimer:correct-20.6.0-changelog -> nodejs:main
Labels     fast-track, author ready, release, commit-queue-squash
Commits    1
 - doc: correct attribution in v20.6.0 changelog
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/50564
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50564
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 05 Nov 2023 15:23:59 GMT
   ✔  Approvals: 1
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50564#pullrequestreview-1716407245
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 136 more hours to land (or 16 hours if there is one more approval) (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6777728206
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ovflowd
ovflowd approved these changes Nov 7, 2023
View reviewed changes
@JakobJingleheimer JakobJingleheimer added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 7, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c5e1fd0 into main Nov 7, 2023
@nodejs-github-bot
nodejs-github-bot deleted the correct-20.6.0-changelog branch November 7, 2023 10:25
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in c5e1fd0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Nov 11, 2023
@JakobJingleheimer @targos
doc: correct attribution in v20.6.0 changelog
9f69b59 
PR-URL: #50564
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@JakobJingleheimer @targos
doc: correct attribution in v20.6.0 changelog
479c1ea 
PR-URL: #50564
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@JakobJingleheimer @UlisesGascon
doc: correct attribution in v20.6.0 changelog
ba6d427 
PR-URL: #50564
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
@targos targos removed the release Issues and PRs related to Node.js releases. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes
@ovflowd ovflowd ovflowd approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@JakobJingleheimer @nodejs-github-bot @UlisesGascon @ovflowd @aduh95 @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.