GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — benchmark: add undici websocket benchmark by Ch3nYuY · Pull Request #50586 · nodejs/node ConversationRefs: nodejs/performance#114 I added a simple benchmark for the undici websocket. I modified the client in https://github.com/websockets/ws/blob/master/bench/speed.js to use undici instead. Platform 20.x vs 21.x
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
anonrig
reviewed
Uh oh!
There was an error while loading. Please reload this page.
lpinca
reviewed
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
KhafraDev
reviewed
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
lpinca
reviewed
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
lpinca
reviewed
Uh oh!
There was an error while loading. Please reload this page.
lpinca
reviewed
Uh oh!
There was an error while loading. Please reload this page.
lpinca
reviewed
Uh oh!
There was an error while loading. Please reload this page.
lpinca
reviewed
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
There is a typo in a commit message ("benchamrk" -> "benchmark") but I think we will squash commits so it does not matter. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@lpinca I noticed that you have approved this PR for three weeks now, but it has not been merged yet. Is it still waiting for approval from other reviewers? Thank you. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
My bad, I've been very busy the last few weeks.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Commit Queue failed- Loading data for nodejs/node/pull/50586 ✔ Done loading data for nodejs/node/pull/50586 ----------------------------------- PR info ------------------------------------ Title benchmark: add undici websocket benchmark (#50586) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch chenyuyang2022:ws-bench -> nodejs:main Labels benchmark, commit-queue-squash Commits 8 - benchmark: add undici websocket benchmark - benchmark: update websocket server - benchmark: update undici benchmark - benchamrk: update undici websocket benchmark - test: add test/benchmark/test-benchmark-websocket.js - update undici websocket benchmark & test - fix lint error - update undici websocket benchmark Committers 1 - Chenyu Yang PR-URL: https://github.com/nodejs/node/pull/50586 Refs: https://github.com/nodejs/performance/issues/114 Reviewed-By: Luigi Pinca Reviewed-By: Matthew Aitken ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50586 Refs: https://github.com/nodejs/performance/issues/114 Reviewed-By: Luigi Pinca Reviewed-By: Matthew Aitken -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 07 Nov 2023 03:49:19 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50586#pullrequestreview-1729891063 ✔ - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/50586#pullrequestreview-1765869891 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7105461887 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in 212a972 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Refs: nodejs/performance#114 PR-URL: #50586 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Refs: nodejs/performance#114 PR-URL: #50586 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.