GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: document non-node_modules-only runtime deprecation by joyeecheung · Pull Request #50748 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Nov 15, 2023

Copy link
Copy Markdown
Member

We already have this special kind of runtime deprecation for Buffer constructors which does not fit into the original description of runtiem deprecations. Document this kind of deprecation separately.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung
doc: document non-node_modules-only runtime deprecation
5c9fe47 
We already have this special kind of runtime deprecation for
Buffer constructors which does not fit into the original
description of runtiem deprecations. Document this kind of
deprecation separately.
@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to Node.js documentation. labels Nov 15, 2023
@joyeecheung

joyeecheung commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth
GeoffreyBooth approved these changes Nov 15, 2023
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
tniessen
tniessen reviewed Nov 17, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only have one such case and I am not sure if it's a pattern we want to extend upon, so I am also not sure if further distinction into four levels makes sense.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 and RafaelGSS reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@GeoffreyBooth

GeoffreyBooth commented Nov 17, 2023

Copy link
Copy Markdown
Member

We only have one such case and I am not sure if it's a pattern we want to extend upon, so I am also not sure if further distinction into four levels makes sense.

I didn't even know this possibility existed. There are many modules features where we would want such a "my code only" warning.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Nov 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

We only have one such case and I am not sure if it's a pattern we want to extend upon, so I am also not sure if further distinction into four levels makes sense.

The reason why we had this case was because Buffer constructor was too widely used so that we had many complaints from users after emitting the warnings by default and it encouraged disabling warnings (especially for CLIs that spawn child processes). I am fairly certain that this would happen again soon, looking at our recent deprecation discussions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Nov 17, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpinca

lpinca commented Nov 18, 2023

Copy link
Copy Markdown
Member

There is a typo in commit message. runtiem -> runtime.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 18, 2023
View reviewed changes
jasnell
jasnell approved these changes Nov 19, 2023
View reviewed changes
benjamingr
benjamingr approved these changes Nov 19, 2023
View reviewed changes
joyeecheung and others added 2 commits November 20, 2023 18:44
@joyeecheung @GeoffreyBooth
fixup! doc: document non-node_modules-only runtime deprecation
4dca046 
Co-authored-by: Geoffrey Booth <[email protected]>
@joyeecheung @GeoffreyBooth
fixup! doc: document non-node_modules-only runtime deprecation
5673030 
Co-authored-by: Geoffrey Booth <[email protected]>
legendecas
legendecas reviewed Nov 20, 2023
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung @legendecas
fixup! doc: document non-node_modules-only runtime deprecation
ae5ecf5 
Co-authored-by: Chengzhong Wu <[email protected]>
jasnell
jasnell approved these changes Nov 25, 2023
View reviewed changes
@joyeecheung joyeecheung added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Nov 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 28, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3ffe2e8 into nodejs:main Nov 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3ffe2e8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Dec 4, 2023
@joyeecheung @targos
doc: document non-node_modules-only runtime deprecation
30a6f19 
We already have this special kind of runtime deprecation for
Buffer constructors which does not fit into the original
description of runtiem deprecations. Document this kind of
deprecation separately.

PR-URL: #50748
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request Dec 4, 2023
v21.4.0 release proposal #51043
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@joyeecheung @richardlau
doc: document non-node_modules-only runtime deprecation
f182696 
We already have this special kind of runtime deprecation for
Buffer constructors which does not fit into the original
description of runtiem deprecations. Document this kind of
deprecation separately.

PR-URL: #50748
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen left review comments
@legendecas legendecas legendecas left review comments
@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@joyeecheung @GeoffreyBooth @lpinca @nodejs-github-bot @mcollina @jasnell @benjamingr @tniessen @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.