GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: replace forEach to for.. test-webcrypto-export-import-cfrg.js by aparzi · Pull Request #50785 · nodejs/node

Conversation

@aparzi

@aparzi aparzi commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

fix for loop

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 18, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
jasnell
jasnell approved these changes Nov 19, 2023
View reviewed changes
RafaelGSS
RafaelGSS requested changes Nov 24, 2023
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you follow our commit guidelines? You might want to squash all the commits too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aparzi

aparzi commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS,
Could you tell me what and how to fix? Thank you
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS

RafaelGSS commented Nov 24, 2023

Copy link
Copy Markdown
Member

Try the following:

git rebase -i HEAD~3

Go to your first commit and change pick to edit, the other two commits you use squash, then it will open a editor to edit the first commit, so you follow our commit guidelines, in this case changing the commit to:

test: replace forEach to for.. test-webcrypto-export-import-cfrg.js
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aparzi
aparzi force-pushed the fix-for-loop branch from 412a692 to fce0619 Compare November 24, 2023 15:31
@aparzi

aparzi commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS,
I collapsed everything into one commit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS reviewed Nov 27, 2023
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aparzi If you look at the commit list, the author doesn't seem your github handle (@aparzi)

Also, the commit length oversizes our commit guideline. See https://github.com/nodejs/node/actions/runs/6982553346/job/19058853209?pr=50785

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aparzi Angelo Parziale
test: replace forEach to for.. test-webcrypto-export-import-cfrg.js
d8178b6
@aparzi
aparzi force-pushed the fix-for-loop branch from fce0619 to d8178b6 Compare November 27, 2023 15:48
@aparzi

aparzi commented Nov 27, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS, could you check now?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aparzi

aparzi commented Nov 28, 2023

Copy link
Copy Markdown
Contributor Author

Hi @RafaelGSS, any news for this PR? Thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 30, 2023
RafaelGSS
RafaelGSS approved these changes Nov 30, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56013/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS changed the title fix for loop test: replace forEach to for.. test-webcrypto-export-import-cfrg.js Dec 1, 2023
@RafaelGSS RafaelGSS added commit-queue PRs queued for automated landing through the Commit Queue. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Dec 1, 2023
RafaelGSS
RafaelGSS approved these changes Dec 1, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 60ffa9f into nodejs:main Dec 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in 60ffa9f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Dec 4, 2023
@aparzi @targos
test: replace forEach to for.. test-webcrypto-export-import-cfrg.js
3a1c664 
PR-URL: #50785
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@targos targos mentioned this pull request Dec 4, 2023
v21.4.0 release proposal #51043
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@aparzi @richardlau
test: replace forEach to for.. test-webcrypto-export-import-cfrg.js
1c28db8 
PR-URL: #50785
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aparzi @RafaelGSS @nodejs-github-bot @jasnell @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.