GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: --input-type default & limitations by shubham9411 · Pull Request #50796 · nodejs/node

Conversation

@shubham9411

@shubham9411 shubham9411 commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

Added additional details about --input-type
Fixes: #50781

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command-line interface. doc Issues and PRs related to Node.js documentation. labels Nov 18, 2023
@shubham9411
shubham9411 force-pushed the doc-cli-input-type branch 2 times, most recently from d1ca25c to f8a79c2 Compare November 18, 2023 17:37
jasnell
jasnell approved these changes Nov 19, 2023
View reviewed changes
@tniessen

tniessen commented Nov 22, 2023

Copy link
Copy Markdown
Member

@shubham9411 Please amend the commit message to comply with our commit message guidelines.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tniessen
tniessen reviewed Nov 22, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nodejs/loaders

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/api/cli.md Outdated
Comment on lines 1033 to 1035

@tniessen tniessen Nov 22, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Default input type can be altered with
[`--experimental-default-type=module`][]
* [`--print`][] does not support `--input-type=module`
* The default input type can be altered with
[`--experimental-default-type=module`][].
* [`--print`][] does not support `--input-type=module`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shubham9411
shubham9411 force-pushed the doc-cli-input-type branch from 592d02f to fc0a6d3 Compare November 22, 2023 14:51
@shubham9411

shubham9411 commented Nov 22, 2023

Copy link
Copy Markdown
Contributor Author

@tniessen Updated please check.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth
GeoffreyBooth reviewed Nov 22, 2023
View reviewed changes
Comment thread doc/api/cli.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Nov 22, 2023
View reviewed changes
Comment thread doc/api/cli.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@shubham9411
shubham9411 requested review from GeoffreyBooth, aduh95 and tniessen November 25, 2023 12:10
aduh95
aduh95 approved these changes Nov 25, 2023
View reviewed changes
aymen94
aymen94 approved these changes Nov 30, 2023
View reviewed changes
@shubham9411
shubham9411 force-pushed the doc-cli-input-type branch from f9e4230 to 4fca349 Compare December 4, 2023 06:28
@shubham9411
doc: added additional details about --input-type
ddeaa0a
@shubham9411
shubham9411 force-pushed the doc-cli-input-type branch from 4fca349 to ddeaa0a Compare December 4, 2023 06:31
GeoffreyBooth
GeoffreyBooth approved these changes Dec 4, 2023
View reviewed changes
aduh95
aduh95 approved these changes Dec 4, 2023
View reviewed changes
@aduh95
aduh95 merged commit 4b0401f into nodejs:main Dec 4, 2023
@aduh95

aduh95 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Landed in 4b0401f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Dec 4, 2023
@shubham9411 @targos
doc: add additional details about --input-type
b281e98 
PR-URL: #50796
Fixes: #50781
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@targos targos mentioned this pull request Dec 4, 2023
v21.4.0 release proposal #51043
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@shubham9411 @richardlau
doc: add additional details about --input-type
37979d7 
PR-URL: #50796
Fixes: #50781
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@aduh95 aduh95 aduh95 approved these changes
@tniessen tniessen Awaiting requested review from tniessen
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cli Issues and PRs related to the Node.js command-line interface. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

document CLI --input-type default & limitations

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@shubham9411 @tniessen @aduh95 @jasnell @GeoffreyBooth @aymen94 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.