GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: update iteration and size in benchmark/crypto/randomBytes.js by lucshi · Pull Request #50868 · nodejs/node

Conversation

@lucshi

@lucshi lucshi commented Nov 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Increase iteration value from 1000 to 10000 to reflect real performance of randomBytes generation. The randomInt has no need to apply this.

Fixes: #50571

Below is the score improvment measured on cascadelake server:

crypto/randomBytes.js size=64:  n=10000 percent=137.85%
crypto/randomBytes.js size=1024:  n=10000 percent=130.66%
crypto/randomBytes.js size=8192:  n=10000 percent=136.31%
crypto/randomBytes.js size=524288:  n=10000 percent=166.50%

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. crypto Issues and PRs related to the crypto subsystem. labels Nov 23, 2023
@lucshi

lucshi commented Nov 24, 2023

Copy link
Copy Markdown
Author

Test ASan should not fail.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad requested changes Nov 26, 2023
View reviewed changes
Comment thread benchmark/crypto/randomBytes.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread benchmark/crypto/randomBytes.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@H4ad

H4ad commented Nov 26, 2023

Copy link
Copy Markdown
Member

Test ASan should not fail.

No worries, I can restart later, sometimes it fails for no reason.

Also, can you update the first commit message to be similar to: Septa2112@a13bb22
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Lei Shi added 2 commits November 27, 2023 16:23
Lei Shi
benchmark: update iteration and size in benchmark/crypto/randomBytes.js
cc466dd 
Fixes: nodejs#50571
Lei Shi
benchmark: update iteration and size in benchmark/crypto/randomBytes.js
00602cc 
Fixes: nodejs#50571
@lucshi
lucshi force-pushed the my-branch-4 branch from 2ee6e0b to cc466dd Compare November 27, 2023 08:45
@lucshi lucshi changed the title benchmark: increase iteration of randomBytes case to appropriate one benchmark: update iteration and size in benchmark/crypto/randomBytes.js Nov 27, 2023
@lucshi

lucshi commented Nov 27, 2023

Copy link
Copy Markdown
Author

Test ASan should not fail.

No worries, I can restart later, sometimes it fails for no reason.

Also, can you update the first commit message to be similar to: Septa2112@a13bb22

Done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad approved these changes Dec 2, 2023
View reviewed changes

@H4ad H4ad left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with just a little fix on linter.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread benchmark/crypto/randomBytes.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Lei Shi @H4ad
Update benchmark/crypto/randomBytes.js
971746f 
Co-authored-by: Vinicius Lourenço <[email protected]>
jasnell
jasnell approved these changes Dec 9, 2023
View reviewed changes
@H4ad H4ad added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Dec 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e158b11 into nodejs:main Dec 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in e158b11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
Lei Shi @RafaelGSS
benchmark: update iteration and size in benchmark/crypto/randomBytes.js
53b16c7 
Fixes: #50571
PR-URL: #50868
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Lei Shi @richardlau
benchmark: update iteration and size in benchmark/crypto/randomBytes.js
278c990 
Fixes: #50571
PR-URL: #50868
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@H4ad H4ad H4ad approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lucshi @H4ad @nodejs-github-bot @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.