GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: update iterations in benchmark/util/inspect-array.js by lucshi · Pull Request #50933 · nodejs/node

Conversation

@lucshi

@lucshi lucshi commented Nov 27, 2023 •
edited by H4ad
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Refs: #50571

Belowing are the score improvement after 10X iteration change:

util/inspect-array.js n=5000
util/inspect-array.js type="denseArray"  n=5000 percent=159.84%
util/inspect-array.js type="sparseArray"  n=5000 percent=245.72%
util/inspect-array.js type="denseArray_showHidden"  n=5000 percent=158.26%
util/inspect-array.js type="denseArray"  n=5000 percent=164.69%
util/inspect-array.js type="denseArray_showHidden"  n=5000 percent=158.53%

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Lei Shi
benchmark: update iterations in benchmark/util/inspect-array.js
48d7a8f 
Fixes: nodejs#50571
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. util Issues and PRs related to the built-in util module. labels Nov 27, 2023
H4ad
H4ad approved these changes Dec 2, 2023
View reviewed changes
@H4ad H4ad added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 2, 2023
UlisesGascon
UlisesGascon approved these changes Dec 2, 2023
View reviewed changes
@H4ad H4ad added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 964046d into nodejs:main Dec 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in 964046d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@H4ad

H4ad commented Dec 4, 2023

Copy link
Copy Markdown
Member

@UlisesGascon do you know why your email was not included in the commit as reviewer?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
Lei Shi @RafaelGSS
benchmark: update iterations in benchmark/util/inspect-array.js
dbee03d 
Fixes: #50571
PR-URL: #50933
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Lei Shi @richardlau
benchmark: update iterations in benchmark/util/inspect-array.js
4fc83e1 
Fixes: #50571
PR-URL: #50933
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes
@H4ad H4ad H4ad approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lucshi @nodejs-github-bot @H4ad @UlisesGascon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.