GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: update iterations in benchmark/util/splice-one.js by lucshi · Pull Request #50935 · nodejs/node

Conversation

@lucshi

@lucshi lucshi commented Nov 27, 2023

Copy link
Copy Markdown

Fixes: #50571

Belowing are the score improvement after 10X iteration change:
util/splice-one.js n=1000000
util/splice-one.js size=10 pos="start" n=1000000 percent=238.22%
util/splice-one.js size=100 pos="start" n=1000000 percent=115.14%
util/splice-one.js size=10 pos="middle" n=1000000 percent=320.22%
util/splice-one.js size=100 pos="middle" n=1000000 percent=130.79%
util/splice-one.js size=10 pos="end" n=1000000 percent=380.13%
util/splice-one.js size=100 pos="end" n=1000000 percent=371.70%
util/splice-one.js size=500 pos="end" n=1000000 percent=373.86%

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Lei Shi
benchmark: update iterations in benchmark/util/splice-one.js
30b22f3 
Fixes: nodejs#50571
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. util Issues and PRs related to the built-in util module. labels Nov 27, 2023
@lucshi

lucshi commented Nov 28, 2023

Copy link
Copy Markdown
Author

close this due to duplicated with #50698
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lucshi lucshi closed this Nov 28, 2023
@lucshi
lucshi deleted the util/splice-one.js branch November 28, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lucshi @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.