GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — benchmark: update iterations in benchmark/util/splice-one.js by Septa2112 · Pull Request #50698 · nodejs/node

Conversation

Septa2112 commented Nov 13, 2023

Copy link

Copy Markdown

Contributor

Refs: #50571

In case util/splice-one.js, when only pos=end I found that the performance gap between node-21.x and node-20.x increased from -15% to 5% after I changed iterations from default 1e5 to 5e6. (node-20.x is the baseline.)

To make sure there was no problem with this modification, I tested the other 8 situations in this case (there are 9 situations in total, 3 types of pos, 3 types of size).

Here is the tests data and the new binary is node 21.x.

node-21.x vs node-20.x

pos=end

util/splice-one.js size=10 pos='end' n=100000        ***    -15.03 %       ±0.82% ±1.09% ±1.42%
util/splice-one.js size=10 pos='end' n=1000000        ***     -1.63 %       ±0.36% ±0.49% ±0.63%
util/splice-one.js size=10 pos='end' n=5000000        ***      5.07 %       ±0.52% ±0.70% ±0.93%

util/splice-one.js size=100 pos='end' n=100000        ***    -14.96 %       ±0.91% ±1.21% ±1.58%
util/splice-one.js size=100 pos='end' n=1000000        ***     -1.85 %       ±0.38% ±0.51% ±0.67%
util/splice-one.js size=100 pos='end' n=5000000        ***      4.59 %       ±0.20% ±0.26% ±0.35%

util/splice-one.js size=500 pos='end' n=100000        ***    -16.60 %       ±0.84% ±1.12% ±1.47%
util/splice-one.js size=500 pos='end' n=1000000        ***     -1.60 %       ±0.45% ±0.60% ±0.79%
util/splice-one.js size=500 pos='end' n=5000000        ***      4.61 %       ±0.20% ±0.26% ±0.35%

pos=middle

util/splice-one.js size=10 pos='middle' n=100000        ***     -4.40 %       ±0.84% ±1.12% ±1.46%
util/splice-one.js size=10 pos='middle' n=1000000                -0.70 %       ±2.08% ±2.79% ±3.69%
util/splice-one.js size=10 pos='middle' n=5000000        ***      2.64 %       ±0.37% ±0.50% ±0.65%

util/splice-one.js size=100 pos='middle' n=100000        ***     -1.69 %       ±0.43% ±0.58% ±0.75%
util/splice-one.js size=100 pos='middle' n=1000000         **      1.49 %       ±1.00% ±1.35% ±1.79%
util/splice-one.js size=100 pos='middle' n=5000000         **      1.60 %       ±1.05% ±1.42% ±1.88%

util/splice-one.js size=500 pos='middle' n=100000        ***     -0.79 %       ±0.28% ±0.37% ±0.49%
util/splice-one.js size=500 pos='middle' n=1000000        ***     -0.17 %       ±0.06% ±0.08% ±0.10%
util/splice-one.js size=500 pos='middle' n=5000000        ***     -0.11 %       ±0.04% ±0.06% ±0.07%

pos=start

util/splice-one.js size=10 pos='start' n=100000        ***     -4.13 %       ±0.57% ±0.75% ±0.98%
util/splice-one.js size=10 pos='start' n=1000000          *     -1.17 %       ±0.89% ±1.20% ±1.59%
util/splice-one.js size=10 pos='start' n=5000000        ***      0.36 %       ±0.16% ±0.22% ±0.28%

util/splice-one.js size=100 pos='start' n=100000        ***     -0.65 %       ±0.31% ±0.41% ±0.54%
util/splice-one.js size=100 pos='start' n=1000000         **      0.83 %       ±0.49% ±0.65% ±0.87%
util/splice-one.js size=100 pos='start' n=5000000        ***      1.16 %       ±0.52% ±0.69% ±0.92%

util/splice-one.js size=500 pos='start' n=100000          *     -0.14 %       ±0.12% ±0.15% ±0.20%
util/splice-one.js size=500 pos='start' n=1000000                -0.02 %       ±0.07% ±0.09% ±0.12%
util/splice-one.js size=500 pos='start' n=5000000                 0.02 %       ±0.11% ±0.14% ±0.19%

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added benchmark

Issues and PRs related to Node.js benchmarks and benchmarking infrastructure.

util Issues and PRs related to the built-in util module. labels

Nov 13, 2023


          benchmark: update iterations in benchmark/util/splice-one.js

a13bb22

Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations

Refs: nodejs#50571

Septa2112 mentioned this pull request

Nov 17, 2023

The performance gap between node16 and node21 changes as the n of the benchmark changes #50571

Closed

H4ad approved these changes

Nov 17, 2023

View reviewed changes

H4ad added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Nov 17, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 17, 2023

nodejs-github-bot commented Nov 17, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55701/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Nov 21, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55816/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

H4ad added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 26, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 26, 2023

nodejs-github-bot merged commit f8c27e6 into nodejs:main

Nov 26, 2023

nodejs-github-bot commented Nov 26, 2023

Copy link

Copy Markdown

Collaborator

Landed in f8c27e6

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

H4ad mentioned this pull request

Nov 26, 2023

benchmark: increase iteration number to appropriate one #50861

Closed

lucshi pushed a commit to lucshi/node that referenced this pull request

Nov 27, 2023


          benchmark: update iterations in benchmark/util/splice-one.js

6d2e379

Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations

Refs: nodejs#50571
PR-URL: nodejs#50698
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Nov 27, 2023


          benchmark: update iterations in benchmark/util/splice-one.js

8f4258d

Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations

Refs: #50571
PR-URL: #50698
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

lucshi mentioned this pull request

Nov 28, 2023

benchmark: update iterations in benchmark/util/splice-one.js #50935

Closed

RafaelGSS mentioned this pull request

Nov 28, 2023

v21.3.0 proposal #50954

Merged

RafaelGSS pushed a commit that referenced this pull request

Nov 29, 2023


          benchmark: update iterations in benchmark/util/splice-one.js

4a20912

Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations

Refs: #50571
PR-URL: #50698
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023


          benchmark: update iterations in benchmark/util/splice-one.js

3648dab

Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations

Refs: #50571
PR-URL: #50698
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

UlisesGascon mentioned this pull request

Dec 12, 2023

v20.11.0 proposal #51124

Merged

UlisesGascon pushed a commit that referenced this pull request

Dec 13, 2023


          benchmark: update iterations in benchmark/util/splice-one.js

95481dc

Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations

Refs: #50571
PR-URL: #50698
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 15, 2023


          benchmark: update iterations in benchmark/util/splice-one.js

73b188b

Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations

Refs: #50571
PR-URL: #50698
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 19, 2023


          benchmark: update iterations in benchmark/util/splice-one.js

e40a559

Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations

Refs: #50571
PR-URL: #50698
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

Reviewers

H4ad

H4ad approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

benchmark

Issues and PRs related to Node.js benchmarks and benchmarking infrastructure.

util

Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.