GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove flicker on page load on dark theme by demakoff · Pull Request #50942 · nodejs/node

Conversation

@demakoff

@demakoff demakoff commented Nov 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Theme applying logic gets loaded and executed in async mode, so often there is a
delay in applying the proper theme to a page which leads to flicker on dark theme.

Resolved by moving critical logic to the page head (sync script). No impact on performance was detected.

Before:
UI
flicker_before

Performance

image

After:

UI
flicker_after

Performance

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@demakoff
doc: remove flicker on page load on dark theme
c3f9df7 
Theme applying logic get loaded and executed in async mode, so often
there is a
delay in applying the proper theme to a page which leads to flicker on
dark theme. Resolved by moving critical logic to the page head
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/nodejs-website
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 27, 2023
MoLow
MoLow approved these changes Nov 27, 2023
View reviewed changes
ovflowd
ovflowd approved these changes Nov 27, 2023
View reviewed changes

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole thing feels hacky, but hey, the whole codebase has been long-time hacky.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
demakoff reacted with laugh emoji
All reactions
  • 😄 1 reaction
@ovflowd ovflowd added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 27, 2023
@github-actions

github-actions Bot commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @ovflowd. Please 👍 to approve.
MoLow and demakoff reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ovflowd ovflowd added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 27, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d42949e into nodejs:main Nov 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in d42949e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@demakoff
demakoff deleted the no-flicker-on-load branch November 27, 2023 16:18
targos pushed a commit that referenced this pull request Dec 4, 2023
@demakoff @targos
doc: remove flicker on page load on dark theme
ec74b93 
Theme applying logic get loaded and executed in async mode, so often
there is a
delay in applying the proper theme to a page which leads to flicker on
dark theme. Resolved by moving critical logic to the page head

PR-URL: #50942
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@targos targos mentioned this pull request Dec 4, 2023
v21.4.0 release proposal #51043
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@demakoff @richardlau
doc: remove flicker on page load on dark theme
e059878 
Theme applying logic get loaded and executed in async mode, so often
there is a
delay in applying the proper theme to a page which leads to flicker on
dark theme. Resolved by moving critical logic to the page head

PR-URL: #50942
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
aduh95 pushed a commit that referenced this pull request Feb 10, 2025
@demakoff @aduh95
doc: remove flicker on page load on dark theme
91cce27 
Theme applying logic get loaded and executed in async mode, so often
there is a
delay in applying the proper theme to a page which leads to flicker on
dark theme. Resolved by moving critical logic to the page head

PR-URL: #50942
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@github-actions github-actions Bot mentioned this pull request Feb 18, 2025
2025-02-20, Version 18.20.7 'Hydrogen' (LTS) #57122
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes
@ovflowd ovflowd ovflowd approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@demakoff @nodejs-github-bot @MoLow @ovflowd
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.