GeezerVison

Review requested:

• @nodejs/security-wg

Fast-track has been requested by @anonrig. Please 👍 to approve.

CI: https://ci.nodejs.org/job/node-test-pull-request/56024/

CI: https://ci.nodejs.org/job/node-test-pull-request/56026/

Hello @anonrig while checking the status of the CI, I noticed that in both runs this PR had, all of the Windows ARM64 tests failed. From what I saw, the error always seems to be Error: Invalid package config and is usually triggered when calling modulesBinding.readPackageJSON.

cc @lemire

@StefanStojanovic @anonrig The issue is verified. There has been a regression. Working a patch to fix this regression on ARM64 Windows.

@StefanStojanovic @anonrig The regression is with version 3.6. Version 3.5 did not have an issue.

Update. The regression is with 3.6.1. Version 3.6.0 is fine.

Ok. Version 3.6.2 has the fix, and it is out:

https://github.com/simdjson/simdjson/releases/tag/v3.6.2

Ok. Version 3.6.2 has the fix, and it is out:

https://github.com/simdjson/simdjson/releases/tag/v3.6.2

Thanks for addressing this quickly!

@StefanStojanovic I bought an ARM-based developer kit for this very purpose.

It is precisely because I tried to fine tune the support that I got in trouble.

I am still unhappy about the code generation. I think Microsoft needs to generate better ARM binaries from Visual Studio. It is not at all at the level of LLVM.

If possible, I'd recommend building the Windows binaries with ClangCL. It would assuredly be faster.

@StefanStojanovic I bought an ARM-based developer kit for this very purpose.

It is precisely because I tried to fine tune the support that I got in trouble.

I am still unhappy about the code generation. I think Microsoft needs to generate better ARM binaries from Visual Studio. It is not at all at the level of LLVM.

If possible, I'd recommend building the Windows binaries with ClangCL. It would assuredly be faster.

I understand your concerns @lemire but currently, ClangCL cannot be used for building on Windows. One thing that comes to mind is for simdjson to use #ifdef to separate Clang and MSVC compilation on Windows. That way you'd be able to get better code generation with Clang, and MSVC would not have the regression.

@StefanStojanovic The problem is not supporting Visual Studio, nor is it that it impacts other compilers (it does not, we already use macros).

The problem is that when you stare at the generated code from Visual Studio, you know that you are leaving performance on the table for no good reason.

The problem is that Visual Studio builds slowly and generate slow code compared to LLVM (clang):

https://lemire.me/blog/2023/02/27/visual-studio-versus-clangcl/

Google builds Chrome under Windows LLVM:

https://blog.llvm.org/2018/03/clang-is-now-used-to-build-chrome-for.html

Firefox is built using LLVM under Windows:

https://www.phoronix.com/news/Firefox-Clang-LTO-All-Platforms

I tried to build Node.js with ClangCL but there are many roadblocks. See #35433 (help appreciated!).

@targos There you go!

CI: https://ci.nodejs.org/job/node-test-pull-request/56106/

CI: https://ci.nodejs.org/job/node-test-pull-request/56115/

Landed in c97322a...ac9e594