GeezerVison

- Loading data for nodejs/node/pull/50990
✔  Done loading data for nodejs/node/pull/50990
----------------------------------- PR info ------------------------------------
Title      fs: use w flag for writeFileSync with utf8 encoding when flag not specified (#50990)
Author     Murilo Kakazu  (@MuriloKakazu, first-time contributor)
Branch     MuriloKakazu:fix/default-flag-fs-write-file-sync -> nodejs:main
Labels     fs, author ready, needs-ci
Commits    2
 - fs: use default w flag for writeFileSync with utf8 encoding
 - fs: add tests for writeFileSync with no flag
Committers 1
 - Murilo Kakazu 
PR-URL: https://github.com/nodejs/node/pull/50990
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50990
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 01 Dec 2023 07:05:02 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50990#pullrequestreview-1760486535
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50990#pullrequestreview-1760934016
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-12-02T18:04:37Z: https://ci.nodejs.org/job/node-test-pull-request/56046/
- Querying data for job/node-test-pull-request/56046/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 50990
From https://github.com/nodejs/node
 * branch                  refs/pull/50990/merge -> FETCH_HEAD
✔  Fetched commits as 23031d9b0a56..aaa4edda7d2e
--------------------------------------------------------------------------------
Auto-merging lib/fs.js
[main 2fba1f3a18] fs: use default w flag for writeFileSync with utf8 encoding
 Author: Murilo Kakazu 
 Date: Fri Dec 1 03:45:10 2023 -0300
 1 file changed, 3 insertions(+), 3 deletions(-)
[main 934e830937] fs: add tests for writeFileSync with no flag
 Author: Murilo Kakazu 
 Date: Fri Dec 1 13:46:14 2023 -0300
 1 file changed, 16 insertions(+)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fs: use default w flag for writeFileSync with utf8 encoding
PR-URL: #50990

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Yagiz Nizipli [email protected]
[detached HEAD 7d6cf7982e] fs: use default w flag for writeFileSync with utf8 encoding

Author: Murilo Kakazu [email protected]

Date: Fri Dec 1 03:45:10 2023 -0300

1 file changed, 3 insertions(+), 3 deletions(-)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fs: add tests for writeFileSync with no flag
PR-URL: #50990

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Yagiz Nizipli [email protected]
[detached HEAD 5220933a12] fs: add tests for writeFileSync with no flag

Author: Murilo Kakazu [email protected]

Date: Fri Dec 1 13:46:14 2023 -0300

1 file changed, 16 insertions(+)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.