GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — module: document `parentURL` in register options by privatenumber · Pull Request #51039 · nodejs/node Conversation
|
|
Review requested:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
5ab0d1c to
03fba68
Compare
There was an error while loading. Please reload this page.
|
Can you please confirm that it is supported there? I remember us debating whether to support If it’s supported in both, is that what we want? What happens if you define it in both places? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This was answered in #51039 (comment) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Commit Queue failed- Loading data for nodejs/node/pull/51039 ✔ Done loading data for nodejs/node/pull/51039 ----------------------------------- PR info ------------------------------------ Title module: document `parentURL` in register options (#51039) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch privatenumber:module-docs-parentURL -> nodejs:main Labels doc, module, author ready Commits 3 - module: document parentURL in register options - Merge branch 'main' into module-docs-parentURL - Update doc/api/module.md Committers 2 - Hiroki Osame - GitHub PR-URL: https://github.com/nodejs/node/pull/51039 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Jacob Smith Reviewed-By: Geoffrey Booth ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51039 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Jacob Smith Reviewed-By: Geoffrey Booth -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 04 Dec 2023 05:08:14 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763062424 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763255497 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763362015 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763999641 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51039 From https://github.com/nodejs/node * branch refs/pull/51039/merge -> FETCH_HEAD ✔ Fetched commits as ac9e594e3224..243207ade200 -------------------------------------------------------------------------------- error: commit 042ae1fc72072eaa78b12f928629593efbeba626 is a merge but no -m option was given. fatal: cherry-pick failed [main e2151c7755] module: document parentURL in register options Author: Hiroki Osame Date: Mon Dec 4 14:06:04 2023 +0900 1 file changed, 4 insertions(+) ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/7110494786 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
e1ceacf to
50b808e
Compare
|
Landed in 342ddb0 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: #51039 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
PR-URL: #51039 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.