GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — module: document `parentURL` in register options by privatenumber · Pull Request #51039 · nodejs/node

Conversation

@privatenumber

@privatenumber privatenumber commented Dec 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The parentURL property was missing in options documentation

Development

Ran make test-doc to lint docs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem. labels Dec 4, 2023
aduh95
aduh95 reviewed Dec 4, 2023
View reviewed changes
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@privatenumber
privatenumber force-pushed the module-docs-parentURL branch from 5ab0d1c to 03fba68 Compare December 4, 2023 13:02
aduh95
aduh95 reviewed Dec 4, 2023
View reviewed changes
Comment thread doc/api/module.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 approved these changes Dec 4, 2023
View reviewed changes
@GeoffreyBooth

GeoffreyBooth commented Dec 4, 2023

Copy link
Copy Markdown
Member

Can you please confirm that it is supported there? I remember us debating whether to support parentURL as the second argument or within options or both; I know it’s supported as the second argument, is it also supported in options?

If it’s supported in both, is that what we want? What happens if you define it in both places?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca approved these changes Dec 4, 2023
View reviewed changes
@JakobJingleheimer

JakobJingleheimer commented Dec 4, 2023

Copy link
Copy Markdown
Member

Can you please confirm that it is supported there? I remember us debating whether to support parentURL as the second argument or within options or both; I know it’s supported as the second argument, is it also supported in options?

If it’s supported in both, is that what we want? What happens if you define it in both places?

This was answered in #51039 (comment)

privatenumber reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JakobJingleheimer
JakobJingleheimer approved these changes Dec 4, 2023
View reviewed changes
GeoffreyBooth
GeoffreyBooth approved these changes Dec 5, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56094/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@GeoffreyBooth GeoffreyBooth added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 5, 2023
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 5, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51039
✔  Done loading data for nodejs/node/pull/51039
----------------------------------- PR info ------------------------------------
Title      module: document `parentURL` in register options (#51039)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     privatenumber:module-docs-parentURL -> nodejs:main
Labels     doc, module, author ready
Commits    3
 - module: document parentURL in register options
 - Merge branch 'main' into module-docs-parentURL
 - Update doc/api/module.md
Committers 2
 - Hiroki Osame 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/51039
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jacob Smith 
Reviewed-By: Geoffrey Booth 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51039
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jacob Smith 
Reviewed-By: Geoffrey Booth 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 04 Dec 2023 05:08:14 GMT
   ✔  Approvals: 4
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763062424
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763255497
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763362015
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/51039#pullrequestreview-1763999641
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51039
From https://github.com/nodejs/node
 * branch                  refs/pull/51039/merge -> FETCH_HEAD
✔  Fetched commits as ac9e594e3224..243207ade200
--------------------------------------------------------------------------------
error: commit 042ae1fc72072eaa78b12f928629593efbeba626 is a merge but no -m option was given.
fatal: cherry-pick failed
[main e2151c7755] module: document parentURL in register options
 Author: Hiroki Osame 
 Date: Mon Dec 4 14:06:04 2023 +0900
 1 file changed, 4 insertions(+)
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/7110494786
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@privatenumber
module: document parentURL in register options
50b808e
@privatenumber
privatenumber force-pushed the module-docs-parentURL branch from e1ceacf to 50b808e Compare December 6, 2023 06:37
aduh95
aduh95 approved these changes Dec 6, 2023
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Dec 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 6, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 342ddb0 into nodejs:main Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 342ddb0

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@privatenumber @RafaelGSS
module: document parentURL in register options
c0e5e74
PR-URL: #51039
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@privatenumber @richardlau
module: document parentURL in register options
43e9f0b
PR-URL: #51039
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@lpinca lpinca lpinca approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@privatenumber @nodejs-github-bot @GeoffreyBooth @JakobJingleheimer @lpinca @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.