GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: fix infinite loop when files are undefined in test runner by pulkit-30 · Pull Request #51047 · nodejs/node

Conversation

@pulkit-30

@pulkit-30 pulkit-30 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

fix: #48823

code:

import { run } from 'node:test'
import { tap } from 'node:test/reporters';

const stream = run({ files: undefined }).compose(tap)

stream.pipe(process.stdout);

running without --test flag

TAP version 13
# TAP version 13
# 1..0
# \# tests 0
# \# suites 0
# \# pass 0
# \# fail 0
# \# cancelled 0
# \# skipped 0
# \# todo 0
# \# duration_ms 4.814625
# Subtest: /Users/pulkitgupta/Desktop/node/index.mjs
ok 1 - /Users/pulkitgupta/Desktop/node/index.mjs
  ---
  duration_ms: 68.923583
  ...
1..1
# tests 1
# suites 0
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 76.718041

running with --test flag.

TAP version 13
1..0
# tests 0
# suites 0
# pass 0
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 5.461375
✔ index.mjs (81.525375ms)
ℹ tests 1
ℹ suites 0
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 93.773375

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and tonivj5 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 4, 2023
benjamingr
benjamingr approved these changes Dec 4, 2023
View reviewed changes
MoLow
MoLow reviewed Dec 5, 2023
View reviewed changes
Comment thread lib/internal/test_runner/runner.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

MoLow
MoLow approved these changes Dec 5, 2023
View reviewed changes
@pulkit-30
pulkit-30 force-pushed the fix-48823 branch from 929ddde to 95c336b Compare December 6, 2023 01:58
MoLow
MoLow approved these changes Dec 6, 2023
View reviewed changes
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Dec 6, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56121/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pulkit-30 pulkit-30 changed the title test_runner: infinite loop when files are undefined in run() test_runner: infinite loop when files are undefined in run() Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56156/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pulkit-30
pulkit-30 force-pushed the fix-48823 branch from 95c336b to 3710117 Compare December 8, 2023 08:32
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56160/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 8, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56162/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56165/

pulkit-30 reacted with confused emoji
All reactions
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell
jasnell approved these changes Dec 9, 2023
View reviewed changes
@pulkit-30

pulkit-30 commented Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

Please re request-ci for this pr

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56178/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pulkit-30
test_runner: fix infinite loop when files are undefined in test runner
a1a0da7
@pulkit-30
pulkit-30 force-pushed the fix-48823 branch from 3710117 to a1a0da7 Compare December 10, 2023 06:23
@pulkit-30 pulkit-30 changed the title test_runner: infinite loop when files are undefined in run() test_runner: fix infinite loop when files are undefined in test runner Dec 10, 2023
@MoLow

MoLow commented Dec 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@pulkit-30 any reason you keep updating the PR? it prevents landing it

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 10, 2023
@pulkit-30

pulkit-30 commented Dec 10, 2023

Copy link
Copy Markdown
Contributor Author

@pulkit-30 any reason you keep updating the PR? it prevents landing it

Sorry @MoLow, I don’t know that. I was worried about failing ci.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56191/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56193/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56201/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 10, 2023
MoLow
MoLow approved these changes Dec 10, 2023
View reviewed changes
@MoLow MoLow removed the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Dec 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f801b58 into nodejs:main Dec 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in f801b58

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@pulkit-30 @RafaelGSS
test_runner: fix infinite loop when files are undefined in test runner
d5c9adf
PR-URL: #51047
Fixes: #48823
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@pulkit-30 @richardlau
test_runner: fix infinite loop when files are undefined in test runner
b8f0ea6
PR-URL: #51047
Fixes: #48823
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[node:test] Infinite loop occurs when files is empty

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pulkit-30 @nodejs-github-bot @MoLow @jasnell @benjamingr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.