GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — test_runner: fix infinite loop when files are undefined in test runner by pulkit-30 · Pull Request #51047 · nodejs/node Conversation
Contributor
fix: #48823 code: import { run } from 'node:test' import { tap } from 'node:test/reporters'; const stream = run({ files: undefined }).compose(tap) stream.pipe(process.stdout); running without TAP version 13 # TAP version 13 # 1..0 # \# tests 0 # \# suites 0 # \# pass 0 # \# fail 0 # \# cancelled 0 # \# skipped 0 # \# todo 0 # \# duration_ms 4.814625 # Subtest: /Users/pulkitgupta/Desktop/node/index.mjs ok 1 - /Users/pulkitgupta/Desktop/node/index.mjs --- duration_ms: 68.923583 ... 1..1 # tests 1 # suites 0 # pass 1 # fail 0 # cancelled 0 # skipped 0 # todo 0 # duration_ms 76.718041 running with TAP version 13 1..0 # tests 0 # suites 0 # pass 0 # fail 0 # cancelled 0 # skipped 0 # todo 0 # duration_ms 5.461375 ✔ index.mjs (81.525375ms) ℹ tests 1 ℹ suites 0 ℹ pass 1 ℹ fail 0 ℹ cancelled 0 ℹ skipped 0 ℹ todo 0 ℹ duration_ms 93.773375
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
benjamingr
approved these changes
MoLow
reviewed
Uh oh!
There was an error while loading. Please reload this page.
MoLow
approved these changes
MoLow
approved these changes
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. undefined in run()
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
jasnell
approved these changes
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
@pulkit-30 any reason you keep updating the PR? it prevents landing it |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry @MoLow, I don’t know that. I was worried about failing ci. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in f801b58 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: #51047 Fixes: #48823 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #51047 Fixes: #48823 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
[node:test] Infinite loop occurs whenfiles is empty
There was an error while loading. Please reload this page.