GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: fix warnings from uv for gn build by zcbenz · Pull Request #51069 · nodejs/node

Conversation

@zcbenz

@zcbenz zcbenz commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Fix build failure in GN build caused by upgrade of libuv in #50650, a fast track merge would be appreciated so we can bring CI of GN build to green to continue monitoring the health of GN build .

../../node/deps/uv/src/idna.c:385:30: error: parameter 'w_target_len' set but not used [-Werror,-Wunused-but-set-parameter]
  385 |                       size_t w_target_len) {
      |                              ^
1 error generated.

Note that this parameter was intentionally used by libuv for safety check without being "used", so fixing it in libuv would be tricky as we need to tell the compiler the parameter is used.
https://github.com/libuv/libuv/blob/5e302730cd29cfeb15d32369dd2edfd9d3c82c11/src/idna.c#L383-L404

I'll try to fix it (and some other compiler warnings) in libuv but it will be really helpful to merge this first.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@zcbenz
build: fix warnings from uv for gn build
8502dd9
@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Dec 6, 2023
@zcbenz

zcbenz commented Dec 6, 2023

Copy link
Copy Markdown
Contributor Author

/cc @nodejs/gyp @richardlau

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gengjiawen
gengjiawen approved these changes Dec 6, 2023
View reviewed changes
@gengjiawen gengjiawen added fast-track PRs proposed for a shorter-than-standard waiting period before landing. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Dec 6, 2023
@github-actions

github-actions Bot commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

gengjiawen and lpinca reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Dec 6, 2023
Failed build: node photoionization/node_with_gn#5
Closed
Things blocking a full-featured GN build of upstream Node.js photoionization/node_with_gn#1
Closed
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56124/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56125/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

santigimeno
santigimeno approved these changes Dec 6, 2023
View reviewed changes
lpinca
lpinca approved these changes Dec 6, 2023
View reviewed changes
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 6, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3f4ea7a into nodejs:main Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3f4ea7a

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@zcbenz @RafaelGSS
build: fix warnings from uv for gn build
735bad3
PR-URL: #51069
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@zcbenz @richardlau
build: fix warnings from uv for gn build
bd528c7
PR-URL: #51069
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santigimeno santigimeno santigimeno approved these changes
@lpinca lpinca lpinca approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@zcbenz @nodejs-github-bot @santigimeno @lpinca @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.