GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: throw fchownSync error from c++ by anonrig · Pull Request #51075 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Dec 6, 2023

Copy link
Copy Markdown
Member

Ref: nodejs/performance#106

#49920 seems to be abandoned.

cc @nodejs/fs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction
@anonrig
fs: throw fchownSync error from c++
1a6c120
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. typings Issues and PRs related to internal TypeScript declarations. labels Dec 6, 2023
@anonrig anonrig mentioned this pull request Dec 6, 2023
Performance of node:fs nodejs/performance#106
Open
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 6, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56139/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56145/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Dec 7, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/fs @nodejs/cpp-reviewers appreciate if you could leave a review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CanadaHonk
CanadaHonk approved these changes Dec 7, 2023
View reviewed changes

@CanadaHonk CanadaHonk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Qard
Qard approved these changes Dec 7, 2023
View reviewed changes
@tniessen

tniessen commented Dec 7, 2023

Copy link
Copy Markdown
Member

I believe @H4ad suggested to re-run benchmarks for these changes in nodejs/performance#106.
H4ad reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@H4ad

H4ad commented Dec 7, 2023

Copy link
Copy Markdown
Member

@anonrig Can you update the benchmark of bench-chownSync.js to include this method? Just to see if those changes are still relevant compared to the new improvements made on errors.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Dec 9, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56194/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 12, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3551dc0 into nodejs:main Dec 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3551dc0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Dec 12, 2023

Copy link
Copy Markdown
Member Author

@anonrig Can you update the benchmark of bench-chownSync.js to include this method? Just to see if those changes are still relevant compared to the new improvements made on errors.

I missed this comment. Sorry I just realized that I didn't comment on this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@anonrig @RafaelGSS
fs: throw fchownSync error from c++
35e8f26 
PR-URL: #51075
Refs: nodejs/performance#106
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@anonrig @richardlau
fs: throw fchownSync error from c++
afd5d67 
PR-URL: #51075
Refs: nodejs/performance#106
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes
@jasnell jasnell jasnell approved these changes
+1 more reviewer
@CanadaHonk CanadaHonk CanadaHonk approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@anonrig @nodejs-github-bot @tniessen @H4ad @Qard @jasnell @CanadaHonk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.