GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: deprecate hash constructor by marco-ippolito · Pull Request #51077 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Dec 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Hash is an internal and shouldnt be called directly but through createHash():
https://github.com/nodejs/node/blob/main/doc/api/crypto.md#class-hash
Calling Hash without new qualifier avoids us from moving into ES6 classes.
The idea is to deprecate it, and refactor it with es6 class without exposing it.

@anonrig

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marco-ippolito marco-ippolito added the crypto Issues and PRs related to the crypto subsystem. label Dec 6, 2023
@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to Node.js documentation. labels Dec 6, 2023
@marco-ippolito
marco-ippolito force-pushed the feat/deprecate-hash branch from 5a84550 to 3838e04 Compare December 6, 2023 19:54
anonrig
anonrig reviewed Dec 6, 2023
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito
marco-ippolito force-pushed the feat/deprecate-hash branch from dad2f99 to 7f2906e Compare December 6, 2023 20:01
@marco-ippolito
doc: deprecate hash constructor
ff25004
@marco-ippolito
marco-ippolito force-pushed the feat/deprecate-hash branch from 7f2906e to ff25004 Compare December 6, 2023 20:02
anonrig
anonrig approved these changes Dec 6, 2023
View reviewed changes
@anonrig

anonrig commented Dec 6, 2023

Copy link
Copy Markdown
Member

cc @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad approved these changes Dec 7, 2023
View reviewed changes
@marco-ippolito marco-ippolito added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 7, 2023
jasnell
jasnell approved these changes Dec 9, 2023
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ba3f721 into nodejs:main Dec 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in ba3f721
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@marco-ippolito @RafaelGSS
doc: deprecate hash constructor
26ed4ad 
PR-URL: #51077
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
RafaelGSS added a commit that referenced this pull request Dec 15, 2023
@RafaelGSS
2023-12-19, Version 21.5.0 (Current)
34ddc71 
Notable changes:

deps:
  * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322
doc:
  * deprecate hash constructor (Marco Ippolito) #51077
  * deprecate `dirent.path` (Antoine du Hamel) #51020
module:
  * merge config with `package_json_reader` (Yagiz Nizipli) #50322
src:
  * move package resolver to c++ (Yagiz Nizipli) #50322

PR-URL: #51166
RafaelGSS added a commit that referenced this pull request Dec 19, 2023
@RafaelGSS
2023-12-19, Version 21.5.0 (Current)
8b690a1 
Notable changes:

deps:
  * (SEMVER-MINOR) add simdjson (Yagiz Nizipli) #50322
doc:
  * deprecate hash constructor (Marco Ippolito) #51077
  * deprecate `dirent.path` (Antoine du Hamel) #51020
module:
  * merge config with `package_json_reader` (Yagiz Nizipli) #50322
src:
  * move package resolver to c++ (Yagiz Nizipli) #50322

PR-URL: #51166
@joyeecheung joyeecheung mentioned this pull request Feb 25, 2024
fs: expose BigIntStats, StatFs, FSWatcher, StatWatcher classes #51681
Closed
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito @richardlau
doc: deprecate hash constructor
f2b4626 
PR-URL: #51077
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@H4ad H4ad H4ad approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@marco-ippolito @anonrig @nodejs-github-bot @jasnell @H4ad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.