GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix broken env fuzzer by initializing process by AdamKorcz · Pull Request #51080 · nodejs/node

Conversation

@AdamKorcz

@AdamKorcz AdamKorcz commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Fixes a broken fuzzer.

It looks like the fuzzer is leaking memory, but it is so slow that it is hard to tell. Once the fuzzer starts running on OSS-Fuzz again, we should get good feedback. If it has a leak, then I plan to fix it over the next couple of weeks; If anyone can spot a possible leak without running it, it would be a great help.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Dec 6, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56146/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AdamKorcz AdamKorcz closed this Dec 7, 2023
@AdamKorcz AdamKorcz reopened this Dec 7, 2023
jasnell
jasnell approved these changes Dec 9, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56211/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AdamKorcz
AdamKorcz force-pushed the fix-fuzz-build branch from 105a7cf to 5f55806 Compare December 11, 2023 13:56
@AdamKorcz AdamKorcz changed the title test: fix broken fuzzer test: fix broken env fuzzer by initializing process Dec 11, 2023
@AdamKorcz AdamKorcz mentioned this pull request Dec 12, 2023
Security initiative in December 2023: fuzzing Nodejs: https://github.com/google/oss-fuzz/tree/master/projects/nodejs nodejs/security-wg#1159
Closed
joyeecheung
joyeecheung approved these changes Dec 15, 2023
View reviewed changes

@joyeecheung joyeecheung left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I do wonder why this is not using node::InitializeOncePerProcess() instead..

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 15, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56321/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Dec 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It looks like the fuzzer is leaking memory, but it is so slow that it is hard to tell.

Actually I just noticed that it seems the fuzzers aren't tearing down the platform etc. properly. See

node/test/cctest/node_test_fixture.cc

Lines 36 to 43 in b68fa59

void NodeTestEnvironment::TearDown() {
cppgc::ShutdownProcess();
v8::V8::Dispose();
v8::V8::DisposePlatform();
NodeZeroIsolateTestFixture::platform->Shutdown();
NodeZeroIsolateTestFixture::platform.reset(nullptr);
NodeZeroIsolateTestFixture::tracing_agent.reset(nullptr);
}
for an example
AdamKorcz reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AdamKorcz

AdamKorcz commented Dec 15, 2023

Copy link
Copy Markdown
Contributor Author

It looks like the fuzzer is leaking memory, but it is so slow that it is hard to tell.

Actually I just noticed that it seems the fuzzers aren't tearing down the platform etc. properly. See

node/test/cctest/node_test_fixture.cc

Lines 36 to 43 in b68fa59

void NodeTestEnvironment::TearDown() {
cppgc::ShutdownProcess();
v8::V8::Dispose();
v8::V8::DisposePlatform();
NodeZeroIsolateTestFixture::platform->Shutdown();
NodeZeroIsolateTestFixture::platform.reset(nullptr);
NodeZeroIsolateTestFixture::tracing_agent.reset(nullptr);
}

for an example

Thank you for the feedback. I will test this and make a follow-up PR.
Kifzy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AdamKorcz @aduh95
test: fix broken env fuzzer by initializing process
15e3604 
Signed-off-by: Adam Korczynski <[email protected]>
@aduh95
aduh95 force-pushed the fix-fuzz-build branch from 5f55806 to 15e3604 Compare May 11, 2024 14:49
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 11, 2024
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59111/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59153/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit d9b61db into nodejs:main May 12, 2024
@aduh95

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Landed in d9b61db
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 12, 2024
@AdamKorcz @targos
test: fix broken env fuzzer by initializing process
4d50d51 
Signed-off-by: Adam Korczynski <[email protected]>
PR-URL: #51080
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@AdamKorcz @marco-ippolito
test: fix broken env fuzzer by initializing process
cc74bf7 
Signed-off-by: Adam Korczynski <[email protected]>
PR-URL: #51080
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@AdamKorcz @soophoo
test: fix broken env fuzzer by initializing process
8aaf8aa 
Signed-off-by: Adam Korczynski <[email protected]>
PR-URL: nodejs#51080
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@AdamKorcz @nodejs-github-bot @joyeecheung @aduh95 @jasnell @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.