GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — Updated packages.md and added --experimental-detect-module flag by shubherthi-mitra · Pull Request #51089 · nodejs/node Conversation
|
|
Review requested:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It feels wrong to duplicate what we have in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
@GeoffreyBooth I understand. But I did this after I asked here #51057 to fix the issue mentioned there. I'm new to github. My apology if any trouble caused. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@shubherthi-mitra you didn’t do anything wrong, thank you for the contribution! My question was more for @nodejs/loaders, if we want to repeat the info here like you’ve done in this PR or if we’d rather do it differently, such as by just mentioning the flag’s existence and linking to its primary documentation. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I think this (smaller surface area to update, less chance of divergence). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think what we want is to modify the paragraph added in https://github.com/nodejs/node/pull/50096/files#diff-71a7964a5c439435680952125e31e9dd4fca3a427982e6db86770fd0fbbfde63 to add a mention of the flag (and a link to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Mentioned --experimental-detect-module flag and added its reference to cli.md
I did as you have said. Please check it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
--experimental-detect-module flag and link to cli.md added.
There was an error while loading. Please reload this page.
Mentioned --experimental-defect-module flag in doc and added ref link to cli.md
There was an error while loading. Please reload this page.
Simplified the paragraph under the heading ###Determining module system, mentioning --experimental-detect-module flag and reference to cli.md
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in 37ba7a3, thanks for the contribution 🎉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: #51089 Fixes: #51057 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #51089 Fixes: #51057 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Node can't recognize staticimport of ES module when theres's not explicit marker
There was an error while loading. Please reload this page.