GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v20.x backport] win,tools: upgrade Windows signing to smctl by StefanStojanovic · Pull Request #51116 · nodejs/node

Conversation

@StefanStojanovic

@StefanStojanovic StefanStojanovic commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

As a part of the new signing requirements for Windows, this changes the approach to using the DigiCert cloud HSM service KeyLocker. This change already landed on the main branch in this PR. This is just a port to the LTS version needed for future releases.

Refs: nodejs/build#3491

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StefanStojanovic
win,tools: upgrade Windows signing to smctl
bfc9c84 
As a part of the new signing requrements for Windows change approach to
use the DigiCert cloud HSM service KeyLocker.

PR-URL: nodejs#50956
Fixes: nodejs/build#3491
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v20.x windows Issues and PRs related to the Windows platform. labels Dec 11, 2023
@StefanStojanovic StefanStojanovic changed the title win,tools: upgrade Windows signing to smctl v20 [v20.x backport] win,tools: upgrade Windows signing to smctl Dec 11, 2023
richardlau
richardlau approved these changes Dec 11, 2023
View reviewed changes

@richardlau richardlau left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/releasers It's possible the original commit will cherry-pick cleanly but I'm approving this backport in case it doesn't and we need to land before the usual "two weeks in current".

Please note that the Windows signing certificate we have been using expires on 18 December 2023 (nodejs/build#3491) so any new releases should include this PR so that they start using the new certificate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StefanStojanovic

StefanStojanovic commented Dec 11, 2023

Copy link
Copy Markdown
Contributor Author

It's possible the original commit will cherry-pick cleanly

This was created by cherry-pick, so it should work. I wasn't aware of any policy for backporting commits to LTS branches, so I opened this PR. In case there is another way feel free to let me know how I should do it. Thanks in advance.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@UlisesGascon
UlisesGascon force-pushed the v20.x-staging branch from 423c757 to fd4149d Compare December 13, 2023 09:09
@richardlau richardlau mentioned this pull request Dec 14, 2023
v20.11.0 proposal #51124
Merged
@UlisesGascon
UlisesGascon force-pushed the v20.x-staging branch 2 times, most recently from 4c9099f to 7af8e20 Compare December 20, 2023 15:15
@UlisesGascon
UlisesGascon force-pushed the v20.x-staging branch from a42629c to 435f9c9 Compare January 9, 2024 08:44
@StefanStojanovic

StefanStojanovic commented Jan 16, 2024

Copy link
Copy Markdown
Contributor Author

Since this change was already ported in #51124, I'm closing this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanStojanovic StefanStojanovic closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@StefanStojanovic @richardlau @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.