GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [v20.x backport] win,tools: upgrade Windows signing to smctl by StefanStojanovic · Pull Request #51116 · nodejs/node

[v20.x backport] win,tools: upgrade Windows signing to smctl #51116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

StefanStojanovic wants to merge 1 commit into nodejs:v20.x-staging from JaneaSystems:mefi-new-cert-v20

Uh oh!

There was an error while loading. Please reload this page.

Closed

[v20.x backport] win,tools: upgrade Windows signing to smctl #51116

Changes from all commits

Commits

Show all changes

1 commit

Select commit

bfc9c84

win,tools: upgrade Windows signing to smctl

StefanStojanovic Dec 8, 2023

File filter

Filter by extension .bat (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

21 changes: 9 additions & 12 deletions 21 tools/sign.bat

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -1,15 +1,12 @@
		@echo off

		set timeservers=(http://timestamp.globalsign.com/scripts/timestamp.dll http://timestamp.comodoca.com/authenticode http://timestamp.verisign.com/scripts/timestamp.dll http://tsa.starfieldtech.com)

		for %%s in %timeservers% do (
		signtool sign /a /d "Node.js" /du "https://nodejs.org" /fd SHA256 /t %%s %1
		if not ERRORLEVEL 1 (
		echo Successfully signed %1 using timeserver %%s
		exit /b 0
		)
		echo Signing %1 failed using %%s
		@REM From December 2023, new certificates use DigiCert cloud HSM service for EV signing.
		@REM They provide a client side app smctl.exe for managing certificates and signing process.
		@REM Release CI machines are configured to have it in the PATH so this can be used safely.
		smctl sign -k key_nodejs -i %1
		if not ERRORLEVEL 1 (
		echo Successfully signed %1 using smctl
		exit /b 0
		)

		echo Could not sign %1 using any available timeserver
		exit /b 1
		echo Could not sign %1 using smctl
		exit /b 1

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.