GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add fuzzer for native/js string conversion by AdamKorcz · Pull Request #51120 · nodejs/node

Conversation

@AdamKorcz

@AdamKorcz AdamKorcz commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

Adds a fuzzer for the following APIs:

napi_create_string_utf8
napi_get_value_string_utf8
napi_create_string_latin1
napi_get_value_string_latin1

The PR also adds the fuzzer to Node's OSS-Fuzz build, so that OSS-Fuzz will run this fuzzer continuously.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Dec 11, 2023
@AdamKorcz AdamKorcz mentioned this pull request Dec 12, 2023
Security initiative in December 2023: fuzzing Nodejs: https://github.com/google/oss-fuzz/tree/master/projects/nodejs nodejs/security-wg#1159
Closed
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 15, 2023
anonrig
anonrig approved these changes Dec 15, 2023
View reviewed changes
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 15, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56298/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added the test Issues and PRs related to Node.js core tests and test infrastructure. label Dec 15, 2023
joyeecheung
joyeecheung reviewed Dec 15, 2023
View reviewed changes

@joyeecheung joyeecheung left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not tearing down the platform etc. properly. One possibility is copying what v8's fuzzer does and run the teardown in the destructor of a global variable:

https://github.com/nodejs/node/blob/16e03e79688d51f95dfdbc90f5b8f56e3e995c6c/deps/v8/test/fuzzer/fuzzer-support.cc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
joyeecheung
joyeecheung reviewed Dec 15, 2023
View reviewed changes
Comment thread test/fuzzers/fuzz_strings.cc Outdated

@joyeecheung joyeecheung Dec 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this just use node::InitializeOncePerProcess() instead? Then there's no need to repeat the initialization routines below (and potentially missing some steps whenever there are internal updates), unless there's a reason that those have to be customized (from what I can tell, that's not necessary?)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 10, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 10, 2024
@nodejs-github-bot

nodejs-github-bot commented May 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59083/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59113/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59155/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AdamKorcz @aduh95
test: add fuzzer for native/js string conversion
c8805b8 
Signed-off-by: Adam Korczynski <[email protected]>
PR-URL: nodejs#51120
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95
aduh95 force-pushed the add-string-fuzzers branch from 919306c to c8805b8 Compare May 12, 2024 17:50
@aduh95

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Landed in c8805b8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit c8805b8 into nodejs:main May 12, 2024
targos pushed a commit that referenced this pull request May 12, 2024
@AdamKorcz @targos
test: add fuzzer for native/js string conversion
c676e52 
Signed-off-by: Adam Korczynski <[email protected]>
PR-URL: #51120
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@AdamKorcz @marco-ippolito
test: add fuzzer for native/js string conversion
7dda156 
Signed-off-by: Adam Korczynski <[email protected]>
PR-URL: #51120
Reviewed-By: Yagiz Nizipli <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@AdamKorcz @soophoo
test: add fuzzer for native/js string conversion
8c5fe1c 
Signed-off-by: Adam Korczynski <[email protected]>
PR-URL: nodejs#51120
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung left review comments
@anonrig anonrig anonrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@AdamKorcz @nodejs-github-bot @aduh95 @anonrig @joyeecheung @tniessen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.