GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — streams: fixes for webstreams by MattiasBuelens · Pull Request #51168 · nodejs/node Conversation
Contributor
Follow-up on #50126.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
ljharb
reviewed
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
183
to
190
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if it's always making a new promise, any reason not to do this?
Suggested change
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like that a lot! An
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately, this change causes some tests to fail again... 😞 However, if you remove the async function ensureIsPromise(fn, thisArg, ...args) { return FunctionPrototypeCall(fn, thisArg, ...args); } You still get a fresh Still, I don't like how sensitive these tests are to the number of microtasks. I'll try to fix this in upstream WPT.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
RafaelGSS
pushed a commit
that referenced
this pull request
PR-URL: #51168 Reviewed-By: Matteo Collina <[email protected]>
Merged
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
I guess then we wont backport it, @targos I saw you marked #50107 as dont not land on v20, wdyt |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
On second thought, I think I can rework my changes. Let me try something... 👨🔬 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@marco-ippolito I managed to make it work without #50107, see #52773. However, If we also want to backport #50107, then I'll need to change it up again. 😛 Let me know how you want to proceed. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I marked it dont-land because it depended on #47956, which was dont-land. Feel free to remove the label and backport. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: nodejs#51168 Backport-PR-URL: nodejs#52773 Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #51168 Backport-PR-URL: #52773 Reviewed-By: Matteo Collina <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.