GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — tools: update doc to new version by nodejs-github-bot · Pull Request #51192 · nodejs/node

Conversation

nodejs-github-bot commented Dec 17, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

This is an automated update of doc to new version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label

Dec 17, 2023

nodejs-github-bot commented Dec 17, 2023

Copy link

Copy Markdown

Collaborator Author

Review requested:

@nodejs/web-infra

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label

Dec 17, 2023

marco-ippolito commented Dec 17, 2023

Copy link

Copy Markdown

Member

I think this update should be split into several commits to prevent commit message lint failure

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added the blocked PRs that are blocked by other issues or PRs. label

Dec 17, 2023

aduh95 commented Dec 17, 2023

Copy link

Copy Markdown

Contributor

This is blocked by micromark/micromark#157, see #49988 (comment)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot changed the title ~~tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected]~~ tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected]

Jan 14, 2024

MoLow approved these changes

Jan 14, 2024

View reviewed changes

marco-ippolito approved these changes

Feb 4, 2024

View reviewed changes

aduh95 added the needs-ci PRs that need a full CI run. label

Feb 11, 2024

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Apr 21, 2024

MoLow commented Apr 21, 2024

Copy link

Copy Markdown

Member

running a full CI cycle to check if this can get unblocked

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Apr 21, 2024

nodejs-github-bot commented Apr 21, 2024

Copy link

Copy Markdown

Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/58567/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow commented Apr 21, 2024

Copy link

Copy Markdown

Member

still failing

10:25:08 export const unicodePunctuation = regexCheck(/\p{P}|\p{S}/u);
10:25:08                                              ^^^^^^^^^^^^^^
10:25:08 
10:25:08 SyntaxError: Invalid regular expression: /\p{P}|\p{S}/u: Invalid property name
10:25:08     at compileSourceTextModule (node:internal/modules/esm/utils:337:16)
10:25:08     at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:168:18)
10:25:08     at callTranslator (node:internal/modules/esm/loader:428:14)
10:25:08     at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:434:30)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito force-pushed the actions/tools-update-doc branch from 53c8f72 to fe425f3 Compare

May 8, 2024 09:58

marco-ippolito commented May 8, 2024

Copy link

Copy Markdown

Member

amended commit otherwise we will never land this, I'll fix the tool in another PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito mentioned this pull request

May 8, 2024

tools: fix doc update action #52890

Merged

nodejs-github-bot changed the title ~~tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected]~~ tools: update doc to new version

May 12, 2024

MoLow approved these changes

Jun 2, 2024

View reviewed changes

marco-ippolito approved these changes

Jun 9, 2024

View reviewed changes

jasnell approved these changes

Jul 7, 2024

View reviewed changes

MoLow approved these changes

Jul 28, 2024

View reviewed changes

UlisesGascon approved these changes

Aug 25, 2024

View reviewed changes

avivkeller removed the blocked PRs that are blocked by other issues or PRs. label

Sep 24, 2024

avivkeller commented Sep 24, 2024

Copy link

Copy Markdown

Member

(The blocking PR has been closed)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added the blocked PRs that are blocked by other issues or PRs. label

Sep 24, 2024

aduh95 commented Sep 24, 2024

Copy link

Copy Markdown

Contributor

(The blocking PR has been closed)

And the problem hasn't been addressed, the CI doesn't pass.

avivkeller reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 14, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 14, 2024


          tools: update doc to new version

45e4f9c

aduh95 added request-ci

Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review.

author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed blocked PRs that are blocked by other issues or PRs. labels

Nov 16, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 16, 2024

nodejs-github-bot commented Nov 16, 2024

Copy link

Copy Markdown

Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/63589/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label

Nov 16, 2024

nodejs-github-bot commented Nov 16, 2024

Copy link

Copy Markdown

Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/63590/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Nov 16, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (b02cd41) to head (45e4f9c).
Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #51192      +/-   ##
==========================================
- Coverage   88.42%   87.92%   -0.50%     
==========================================
  Files         654      654              
  Lines      187852   187852              
  Branches    36134    35824     -310     
==========================================
- Hits       166102   165167     -935     
- Misses      14989    15875     +886     
- Partials     6761     6810      +49

see 91 files with indirect coverage changes

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels

Nov 17, 2024

marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 17, 2024

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 17, 2024

nodejs-github-bot commented Nov 17, 2024

Copy link

Copy Markdown

Collaborator Author

Commit Queue failed

- Loading data for nodejs/node/pull/51192
✔  Done loading data for nodejs/node/pull/51192
----------------------------------- PR info ------------------------------------
Title      tools: update doc to new version (#51192)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-doc -> nodejs:main
Labels     doc, tools, author ready, needs-ci, commit-queue-rebase, dont-land-on-v18.x, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x
Commits    2
 - tools: disable doc building when ICU is not available
 - tools: update doc to new version
Committers 2
 - Antoine du Hamel <[email protected]>
 - Node.js GitHub Bot <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/51192
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51192
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - tools: disable doc building when ICU is not available
   ⚠  - tools: update doc to new version
   ℹ  This PR was created on Sun, 17 Dec 2023 00:26:43 GMT
   ✔  Approvals: 4
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2203485934
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2106067988
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2161903820
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/51192#pullrequestreview-2259349505
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-11-16T23:04:18Z: https://ci.nodejs.org/job/node-test-pull-request/63590/
- Querying data for job/node-test-pull-request/63590/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11878353074

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Nov 17, 2024

marco-ippolito approved these changes

Nov 17, 2024

View reviewed changes

marco-ippolito added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Nov 17, 2024

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 17, 2024

nodejs-github-bot commented Nov 17, 2024

Copy link

Copy Markdown

Collaborator Author

Landed in b0051de...b1ee186

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot pushed a commit that referenced this pull request

Nov 17, 2024


          tools: disable doc building when ICU is not available

be34b5e

PR-URL: #51192
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>

nodejs-github-bot added a commit that referenced this pull request

Nov 17, 2024


          tools: update doc to new version

b1ee186

PR-URL: #51192
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>

nodejs-github-bot closed this

Nov 17, 2024

RafaelGSS mentioned this pull request

May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

Reviewers

jasnell

jasnell approved these changes

UlisesGascon

UlisesGascon approved these changes

MoLow

MoLow approved these changes

marco-ippolito

marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue-rebase

PRs the Commit Queue should land as multiple self-contained commits.

doc

Issues and PRs related to Node.js documentation.

dont-land-on-v22.x

PRs that should not land on the v22.x-staging branch and should not be released in v22.x.

needs-ci

PRs that need a full CI run.

tools

Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

nodejs-github-bot commented Dec 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 17, 2023

Uh oh!

marco-ippolito commented Dec 17, 2023

Uh oh!

aduh95 commented Dec 17, 2023

Uh oh!

MoLow commented Apr 21, 2024

Uh oh!

nodejs-github-bot commented Apr 21, 2024

Uh oh!

MoLow commented Apr 21, 2024

Uh oh!

marco-ippolito commented May 8, 2024

Uh oh!

avivkeller commented Sep 24, 2024

Uh oh!

aduh95 commented Sep 24, 2024

Uh oh!

nodejs-github-bot commented Nov 16, 2024

Uh oh!

nodejs-github-bot commented Nov 16, 2024

Uh oh!

codecov Bot commented Nov 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Nov 17, 2024

Uh oh!

nodejs-github-bot commented Nov 17, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nodejs-github-bot commented Dec 17, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Nov 16, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.