GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: mention node:wasi in the Threat Model by RafaelGSS · Pull Request #51211 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Dec 19, 2023

Copy link
Copy Markdown
Member

Following up: #50396 (comment)

cc: @mhdawson

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS
doc: mention node:wasi in the Threat Model
a5bf869
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Dec 19, 2023
UlisesGascon
UlisesGascon approved these changes Dec 19, 2023
View reviewed changes
mhdawson
mhdawson approved these changes Dec 20, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 20, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51211
✔  Done loading data for nodejs/node/pull/51211
----------------------------------- PR info ------------------------------------
Title      doc: mention node:wasi in the Threat Model (#51211)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:document-wasi-threat-model -> nodejs:main
Labels     doc
Commits    1
 - doc: mention node:wasi in the Threat Model
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/51211
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51211
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 19 Dec 2023 00:52:31 GMT
   ✔  Approvals: 1
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/51211#pullrequestreview-1791240304
   ✘  This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7282751023
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-ippolito
marco-ippolito approved these changes Dec 21, 2023
View reviewed changes
@RafaelGSS RafaelGSS added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Dec 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a71210b into nodejs:main Dec 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in a71210b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS added a commit that referenced this pull request Jan 2, 2024
@RafaelGSS
doc: mention node:wasi in the Threat Model
c13a5c0 
PR-URL: #51211
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
v21.6.0 proposal #51342
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@RafaelGSS @richardlau
doc: mention node:wasi in the Threat Model
52d8222 
PR-URL: #51211
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@RafaelGSS @nodejs-github-bot @UlisesGascon @mhdawson @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.