GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: support multi-line values for .env file by IlyasShabi · Pull Request #51289 · nodejs/node

Conversation

IlyasShabi commented Dec 26, 2023

Copy link

Copy Markdown

Member

Following the follow-up, we currently do not handle multi-line values in the .env file.
This PR aims to add this feature based on the implementation in dotenv

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with rocket emoji

All reactions

🚀 1 reaction

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci PRs that need a full CI run. labels

Dec 26, 2023

IlyasShabi commented Dec 26, 2023

Copy link

Copy Markdown

Member Author

cc @anonrig

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

IlyasShabi force-pushed the dot-env-multi-lines branch from f6d0899 to 35eb89c Compare

December 26, 2023 12:58

anonrig self-requested a review

December 26, 2023 13:00

anonrig commented Dec 26, 2023

Copy link

Copy Markdown

Member

@IlyasShabi Can you fix the C++ linting errors?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig added the notable-change PRs with changes that should be highlighted in changelogs. label

Dec 26, 2023

github-actions Bot commented Dec 26, 2023

Copy link

Copy Markdown

Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig reviewed

Dec 26, 2023

View reviewed changes

Comment thread

src/node_dotenv.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_dotenv.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/fixtures/dotenv/valid.env Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/parallel/test-dotenv.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

IlyasShabi force-pushed the dot-env-multi-lines branch 3 times, most recently from 3ca8625 to 876aef7 Compare

December 26, 2023 13:14

RafaelGSS reviewed

Dec 26, 2023

View reviewed changes

RafaelGSS left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the docs too? It should include the version .env start supporting multiline strings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

RafaelGSS reviewed

Dec 26, 2023

View reviewed changes

Comment thread

test/fixtures/dotenv/valid.env Resolved

Uh oh!

There was an error while loading. Please reload this page.

IlyasShabi force-pushed the dot-env-multi-lines branch from 876aef7 to 7089fd7 Compare

December 26, 2023 14:56

anonrig reviewed

Dec 26, 2023

View reviewed changes

Comment thread

src/node_dotenv.cc Outdated

anonrig Dec 26, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe string erase and remove would be faster and more readable than regex replace. The same applies for the next line as well.

str.erase(remove(str.begin(), str.end(), ch), str.end());

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/fixtures/dotenv/valid.env Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_dotenv.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_dotenv.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_dotenv.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/fixtures/dotenv/valid.env Resolved

Uh oh!

There was an error while loading. Please reload this page.

tniessen reviewed

Dec 27, 2023

View reviewed changes

Comment thread

src/node_dotenv.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_dotenv.cc Outdated

tniessen Dec 27, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the parser is exactly compatible with dotenv? #49148 (comment) sounds like dotenv supports multi-line values, and if it does, this implementation should probably be compatible.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

IlyasShabi Dec 30, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tniessen The goal of this PR is to support multi-line values same as dotenv

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

himself65 reacted with eyes emoji

All reactions

👀 1 reaction

IlyasShabi force-pushed the dot-env-multi-lines branch 3 times, most recently from 99d1f88 to e7fe39d Compare

December 31, 2023 09:00

IlyasShabi force-pushed the dot-env-multi-lines branch 5 times, most recently from 3b3c645 to de3d605 Compare

January 7, 2024 09:51

IlyasShabi commented

Jan 7, 2024

View reviewed changes

Comment thread

test/parallel/test-dotenv.js Outdated

IlyasShabi Jan 7, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also adds support for the export keyword. According to dotenv, there may be an export keyword before the key, this keyword is ignored.
Unfortunately, I did not find a test for the export feature in the dotenv test suite.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

IlyasShabi commented Jan 7, 2024

Copy link

Copy Markdown

Member Author

@RafaelGSS @anonrig @tniessen Could you please review it again ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

IlyasShabi force-pushed the dot-env-multi-lines branch from 0e6d3ca to 5ed6c5b Compare

January 7, 2024 18:32

himself65 approved these changes

Jan 7, 2024

View reviewed changes

Comment thread

src/node_dotenv.cc Outdated

himself65 Jan 7, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: https://github.com/motdotla/dotenv/blob/2eed66b107229eb662a7edfe1ef31597c8d53023/lib/main.js#L9

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

anonrig requested changes

Jan 7, 2024

View reviewed changes

Comment thread

src/node_dotenv.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_dotenv.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

UlisesGascon commented Jan 30, 2024

Copy link

Copy Markdown

Member

It seems all macOS devices are down nodejs/build#3616

@anonrig the macos machines are available again, so they are processing the CI pending queue. It can take a while

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label

Jan 31, 2024

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Jan 31, 2024

nodejs-github-bot merged commit 8b28366 into nodejs:main

Jan 31, 2024

nodejs-github-bot commented Jan 31, 2024

Copy link

Copy Markdown

Collaborator

Landed in 8b28366

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

IlyasShabi deleted the dot-env-multi-lines branch

January 31, 2024 13:26

anonrig mentioned this pull request

Jan 31, 2024

.env file support issue tracker #49148

Open

8 tasks done

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Feb 9, 2024


          src: support multi-line values for .env file

57558f1

PR-URL: nodejs#51289
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

victorgomes mentioned this pull request

Feb 14, 2024

src: fix empty string access in dotenv #51757

Closed

targos pushed a commit that referenced this pull request

Feb 15, 2024


          src: support multi-line values for .env file

c7912c3

PR-URL: #51289
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

marco-ippolito mentioned this pull request

Mar 1, 2024

v21.7.0 proposal #51932

Merged

marco-ippolito added a commit that referenced this pull request

Mar 1, 2024


          2024-03-08, Version 21.7.0 (Current)

e5353e9

Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932

marco-ippolito added a commit that referenced this pull request

Mar 1, 2024


          2024-03-08, Version 21.7.0 (Current)

9571f39

Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932

marco-ippolito added a commit that referenced this pull request

Mar 1, 2024


          2024-03-06, Version 21.7.0 (Current)

4533c19

Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932

marco-ippolito added a commit that referenced this pull request

Mar 2, 2024


          2024-03-06, Version 21.7.0 (Current)

bcd4f1a

Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932

marco-ippolito added a commit that referenced this pull request

Mar 5, 2024


          2024-03-06, Version 21.7.0 (Current)

bd81180

Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932

marco-ippolito added a commit that referenced this pull request

Mar 5, 2024


          2024-03-06, Version 21.7.0 (Current)

47e6820

Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932

RafaelGSS pushed a commit that referenced this pull request

Mar 6, 2024


          2024-03-06, Version 21.7.0 (Current)

2246cd9

Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932

IlyasShabi mentioned this pull request

Mar 14, 2024

--env-file parser overrides variables with commented out values #52084

Closed

richardlau pushed a commit that referenced this pull request

Mar 25, 2024


          src: support multi-line values for .env file

c3c0a3e

PR-URL: #51289
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>

richardlau mentioned this pull request

Mar 25, 2024

v20.12.0 proposal #52212

Merged

kibertoad mentioned this pull request

Mar 28, 2024

Loading long env value from a file is crashing Node on Windows #52248

Closed

Reviewers

tniessen

tniessen left review comments

anonrig

anonrig approved these changes

himself65

himself65 approved these changes

RafaelGSS

RafaelGSS approved these changes

+1 more reviewer

fhinkel

fhinkel approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

needs-ci

PRs that need a full CI run.

notable-change

PRs with changes that should be highlighted in changelogs.

semver-minor

PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

IlyasShabi commented Dec 26, 2023

Uh oh!

IlyasShabi commented Dec 26, 2023

Uh oh!

anonrig commented Dec 26, 2023

Uh oh!

github-actions Bot commented Dec 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anonrig Dec 26, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tniessen Dec 27, 2023

Choose a reason for hiding this comment

Uh oh!

IlyasShabi Dec 30, 2023

Choose a reason for hiding this comment

Uh oh!

IlyasShabi Jan 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IlyasShabi commented Jan 7, 2024

Uh oh!

himself65 Jan 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

UlisesGascon commented Jan 30, 2024

Uh oh!

nodejs-github-bot commented Jan 31, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

IlyasShabi Jan 7, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.