GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update V8 to 12.2 by targos · Pull Request #51362 · nodejs/node

Conversation

@targos

@targos targos commented Jan 4, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Main change that affects us: v8/v8@12203e0

Some flaky tests.
I would really appreciate help to investigate these. Node.js 22 is coming close!

12:33:52 not ok 3759 parallel/test-worker-arraybuffer-zerofill
12:33:52   ---
12:33:52   duration_ms: 120024.23700
12:33:52   severity: fail
12:33:52   exitcode: -15
12:33:52   stack: |-
12:33:52     timeout
12:33:52   ...

12:40:34 not ok 3756 parallel/test-net-write-fully-async-hex-string
12:40:34   ---
12:40:34   duration_ms: 120066.81500
12:40:34   severity: fail
12:40:34   exitcode: -15
12:40:34   stack: |-
12:40:34     timeout
12:40:34   ...

18:25:43 not ok 2444 parallel/test-shadow-realm-gc-module
18:25:43   ---
18:25:43   duration_ms: 6465.44100
18:25:43   severity: crashed
18:25:43   exitcode: -6
18:25:43   stack: |-
18:25:43     
18:25:43     <--- Last few GCs --->
18:25:43     .6[1674180:0x7f32cac7f000]     5861 ms: Mark-Compact 18.1 (48.4) -> 15.5 (49.2) MB, pooled: 0 MB, 5.89 / 0.01 ms  (+ 16.5 ms in 0 steps since start of marking, biggest step 0.0 ms, walltime since start of marking 26 ms) (average mu = 0.722, current mu = 0.7[1674180:0x7f32cac7f000]     6033 ms: Mark-Compact 22.4 (50.2) -> 18.8 (52.7) MB, pooled: 0 MB, 33.08 / 0.01 ms  (+ 29.2 ms in 0 steps since start of marking, biggest step 0.0 ms, walltime since start of marking 134 ms) (average mu = 0.666, current mu = 0
18:25:43     
18:25:43     <--- JS stacktrace --->
18:25:43     
18:25:43     FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
18:25:43     ----- Native stack trace -----
18:25:43     
18:25:43   ...

18:46:01 not ok 2691 parallel/test-shadow-realm-gc
18:46:01   ---
18:46:01   duration_ms: 3138.09900
18:46:01   severity: crashed
18:46:01   exitcode: -11
18:46:01   stack: |-

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, BlackIQ, abhaysinghs772, PPROGER, hunghg255, iamthepoe, tungbq, joansebgarcia, gcaaa31928, hausg, and 153 more reacted with thumbs up emoji yanickouellette1982, Dmitriy-Frostoff, mozhuanzuojing, akshitagupta15june, and ssi02014 reacted with laugh emoji bricss, lin72h, ad0x99, DaanQ42, damnitrahul, denisapelnikov, danielgospodinow, aadito123, deki23, marco-ippolito, and 17 more reacted with hooray emoji bricss, filipecorrea, lucasrivoiro, Kuuuuuuuu, rumon5h, kyotrandev, siddharthsabron, damnitrahul, wakidurrahman, denisapelnikov, and 22 more reacted with heart emoji bricss, CogitoBurrito, dtmrc, DaanQ42, damnitrahul, BreadGenie, tryb3l, denisapelnikov, j1m-ryan, lin72h, and 24 more reacted with rocket emoji yvele, damnitrahul, akshitagupta15june, bricss, siosio34, marco-ippolito, guojingkang, parasatiskylar, Dmitriy-Frostoff, ChrisChou-freeman, and 5 more reacted with eyes emoji
All reactions
  • 👍 163 reactions
  • 😄 5 reactions
  • 🎉 27 reactions
  • ❤️ 32 reactions
  • 🚀 34 reactions
  • 👀 15 reactions
@targos targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Jan 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 4, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Jan 4, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos targos mentioned this pull request Jan 4, 2024
Build fails on Windows/MSVC nodejs/node-v8#271
Closed
@targos

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@targos
targos force-pushed the v8-121 branch from 0d05f47 to bc765d0 Compare January 7, 2024 14:05
This was referenced Jan 7, 2024
Build error on macOS 11 nodejs/node-v8#276
Closed
test-inspector-vm-global-accessors-getter-sideeffect fails with debug build nodejs/node-v8#274
Closed
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 7, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 7, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

targos commented Jan 7, 2024

Copy link
Copy Markdown
Member Author

/cc @nodejs/platform-windows @StefanStojanovic We're hitting nodejs/node-v8#271
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 7, 2024

Copy link
Copy Markdown
Member Author

Looks like the build is broken on AIX @nodejs/platform-aix

https://ci.nodejs.org/job/node-test-commit-aix/49875/nodes=aix72-ppc64/console
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 7, 2024

Copy link
Copy Markdown
Member Author

Many failing test on s390: https://ci.nodejs.org/job/node-test-commit-linuxone/41750/#showFailuresLink

@nodejs/platform-s390
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

@nodejs/platform-smartos The SmartOS build is broken (related to d1ccf72): https://ci.nodejs.org/job/node-test-commit-smartos/52823/nodes=smartos20-64/console
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

@nodejs/platform-ppc @nodejs/platform-s390 The V8 CI build errors:

16:08:40 g++: fatal error: Killed signal terminated program cc1plus

https://ci.nodejs.org/job/node-test-commit-v8-linux/5757/nodes=rhel8-ppc64le,v8test=v8test/console
https://ci.nodejs.org/job/node-test-commit-v8-linux/5757/nodes=rhel8-s390x,v8test=v8test/console
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

It looks like 9570832 is not enough. There's a flaky test in debug mode:

./node_g test/sequential/test-worker-fshandles-error-on-termination.js 
$ ./node_g test/sequential/test-worker-fshandles-error-on-termination.js


#
# Fatal error in ../../deps/v8/src/execution/isolate-inl.h, line 105
# Debug check failed: has_exception() == result == ReadOnlyRoots(this).exception() (1 vs. 0).
#
#
#
#FailureMessage Object: 0x16f6ed148
----- Native stack trace -----

 1: 0x1048b5400 node::DumpNativeBacktrace(__sFILE*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
 2: 0x104afddd4 node::NodePlatform::GetStackTracePrinter()::$_3::operator()() const [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
 3: 0x104afdd90 node::NodePlatform::GetStackTracePrinter()::$_3::__invoke() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
 4: 0x106c702f0 V8_Fatal(char const*, int, char const*, ...) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
 5: 0x106c6fe8c std::__1::enable_if<!std::is_function<std::__1::remove_pointer<char>::type>::value && !std::is_enum<char>::value && has_output_operator<char, v8::base::CheckMessageStream>::value, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>::type v8::base::PrintCheckOperand<char>(char) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
 6: 0x104ebb208 v8::internal::Isolate::VerifyBuiltinsResult(v8::internal::Tagged<v8::internal::Object>) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
 7: 0x105a4943c v8::internal::Runtime_PromiseRejectEventFromStack(int, unsigned long*, v8::internal::Isolate*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
 8: 0x10615e7b4 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
 9: 0x1061edabc Builtins_PromiseReject [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
10: 0x1060bc370 Builtins_InterpreterEntryTrampoline [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
11: 0x1061f9420 Builtins_PromiseRejectReactionJob [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
12: 0x1060eb2ec Builtins_RunMicrotasks [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
13: 0x1060b96f4 Builtins_JSRunMicrotasksEntry [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
14: 0x105131e9c v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
15: 0x105133870 v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
16: 0x105133f20 v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
17: 0x105186dec v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
18: 0x105186b0c v8::internal::MicrotaskQueue::PerformCheckpointInternal(v8::Isolate*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
19: 0x1047f7110 node::InternalCallbackScope::Close() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
20: 0x1047f6f2c node::InternalCallbackScope::~InternalCallbackScope() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
21: 0x1047f6a3c node::InternalCallbackScope::~InternalCallbackScope() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
22: 0x1049ec984 node::fs::FSReqPromise<node::AliasedBufferBase<double, v8::Float64Array>>::Reject(v8::Local<v8::Value>) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
23: 0x104a061fc node::fs::FSReqAfterScope::Reject(uv_fs_s*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
24: 0x104a06324 node::fs::FSReqAfterScope::Proceed() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
25: 0x104a06be0 node::fs::AfterOpenFileHandle(uv_fs_s*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
26: 0x1049ee5bc node::MakeLibuvRequestCallback<uv_fs_s, void (*)(uv_fs_s*)>::Wrapper(uv_fs_s*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
27: 0x10608c3c4 uv__fs_done [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
28: 0x10607e4ec uv__work_done [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
29: 0x1060874d0 uv__async_io [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
30: 0x1060aaea0 uv__io_poll [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
31: 0x106087ed0 uv_run [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
32: 0x1047fa37c node::SpinEventLoopInternal(node::Environment*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
33: 0x104ba3c34 node::worker::Worker::Run() [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
34: 0x104ba7cb8 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::operator()(void*) const [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
35: 0x104ba7c64 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/mzasso/git/nodejs/v8-next-update/out/Debug/node]
36: 0x1843de034 _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
37: 0x1843d8e3c thread_start [/usr/lib/system/libsystem_pthread.dylib]
[1]    34458 trace trap  ./node_g test/sequential/test-worker-fshandles-error-on-termination.js
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanStojanovic

StefanStojanovic commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

/cc @nodejs/platform-windows @StefanStojanovic We're hitting nodejs/node-v8#271

Thanks for letting me know. I just got back to work today, so will look into it in the following days.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sumitradawn

sumitradawn commented Jan 8, 2024

Copy link
Copy Markdown

Looks like the build is broken on AIX @nodejs/platform-aix

https://ci.nodejs.org/job/node-test-commit-aix/49875/nodes=aix72-ppc64/console

I have checked and the v8 build is fine for AIX wrt current commit id- ff9dc695ffc0412baf644e4cddfa92b93cd2b978 (HEAD, origin/main, origin/HEAD)

Screenshot 2024-01-08 at 7 51 16 PM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

@sumitradawn This is not with V8 HEAD. It's with 12.1-lkgr
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sumitradawn

sumitradawn commented Jan 9, 2024

Copy link
Copy Markdown

@sumitradawn This is not with V8 HEAD. It's with 12.1-lkgr

@targos I have tried to build Node from the source code on AIX and it is quite fine for me. There might be some memory issue, Can you please try to run the job with -j4 option.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 9, 2024

Copy link
Copy Markdown
Member Author

Run with -j 4: https://ci.nodejs.org/view/All/job/node-test-commit-aix-targos/1/nodes=aix72-ppc64/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eti-p-doray and others added 4 commits March 30, 2024 09:55
@eti-p-doray @etiennep-chromium @targos
src: update default V8 platform to override functions with location
6696855 
Co-authored-by: Etienne Pierre-Doray <[email protected]>
@targos
src: use supported API to get stalled TLA messages
1827161 
Refs: v8/v8@23e3b6f
@targos
test: allow slightly more diff in memory leak test
d5ac47e 
Previous limit was too low for debug builds.
@targos
lib,test: handle new Iterator global
c131f74 
Refs: v8/v8@80fb767
@targos targos mentioned this pull request Mar 30, 2024
Flaky GC-related tests with V8 12.2 #52273
Closed
@targos
test: mark some GC-related tests as flaky
d8b04a9 
Refs: nodejs#52273
@targos targos mentioned this pull request Mar 30, 2024
Flaky test-worker-arraybuffer-zerofill with V8 12.2 #52274
Closed
@targos
test: mark test-worker-arraybuffer-zerofill as flaky
f188183 
Refs: nodejs#52274
@targos
targos force-pushed the v8-121 branch from e7f0082 to f188183 Compare March 30, 2024 09:04
@targos

targos commented Mar 30, 2024

Copy link
Copy Markdown
Member Author

Rebased and added flaky designations to the tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58004/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58005/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Mar 30, 2024
View reviewed changes

@aduh95 aduh95 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the hard work! Non-blocking comment: I wonder if d5ac47e and 59e4518 should be backported

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58007/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS approved these changes Mar 30, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58011/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58012/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos self-assigned this Mar 31, 2024
@targos targos removed the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Mar 31, 2024
targos added a commit that referenced this pull request Mar 31, 2024
@targos
deps: update V8 to 12.2.281.27
09a8440 
PR-URL: #51362
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
targos added a commit that referenced this pull request Mar 31, 2024
@targos
build: reset embedder string to "-node.0"
94f0369 
PR-URL: #51362
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
targos added a commit that referenced this pull request Mar 31, 2024
@targos
src: update NODE_MODULE_VERSION to 124
5cddd3b 
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 12.2.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: #51362
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
targos added a commit that referenced this pull request Mar 31, 2024
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
f366208 
dllexport introduces issues when compiling with MSVC.

PR-URL: #47251
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #51362
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos added a commit that referenced this pull request Mar 31, 2024
@targos
deps: silence irrelevant V8 warning
0423f7e 
PR-URL: #45579
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #51362
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@targos

targos commented Mar 31, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thanks for the reviews, and everyone who helped!

Landed in d9aa33f...9efc84a
sjrd and bricss reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 12, 2024
2024-04-24, Version 22.0.0 (Current) #52505
Merged
@aduh95 aduh95 mentioned this pull request May 11, 2024
v8: update default platform to override functions with location #50289
Closed
@legendecas legendecas mentioned this pull request Jun 13, 2024
node_mksnapshot debug build segfault #53446
Closed
@jazelly jazelly mentioned this pull request May 13, 2025
[v22.x backport] src: initialize privateSymbols for per_context #58217
Closed
@milcho0604 milcho0604 mentioned this pull request Aug 16, 2026
perf(registry): Avoid label array manipulation in the happy path. prometheus/client_js#804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@targos targos

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

14 participants

@targos @nodejs-github-bot @StefanStojanovic @sumitradawn @miladfarca @richardlau @mhdawson @joyeecheung @bahamat @jperkin @mcollina @aduh95 @RafaelGSS @eti-p-doray
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.