GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: update iterations of benchmark/domain/domain-fn-args.js by lucshi · Pull Request #51408 · nodejs/node

Conversation

@lucshi

@lucshi lucshi commented Jan 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes: #50571

Found 40% regression on node20 compared with older version:
benchmark@benchmark-S2600WFT:/luc/node_new$ /home/benchmark/.nvm/versions/node/v16.20.2/bin/node benchmark/domain/domain-fn-args.js
domain/domain-fn-args.js n=10 args=0: 59,126.81519322643
domain/domain-fn-args.js n=10 args=1: 55,949.690038717185
domain/domain-fn-args.js n=10 args=2: 49,182.34353866962
domain/domain-fn-args.js n=10 args=3: 58,395.18356525954

benchmark@benchmark-S2600WFT:~/luc/node_new$ /home/benchmark/.nvm/versions/node/v20.11.1/bin/node benchmark/domain/domain-fn-args.js
domain/domain-fn-args.js n=10 args=0: 38,578.609704063485
domain/domain-fn-args.js n=10 args=1: 38,735.66780291292
domain/domain-fn-args.js n=10 args=2: 39,472.645456698505
domain/domain-fn-args.js n=10 args=3: 39,021.49694266571

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Lei Shi
benchmark: update iterations of benchmark/domain/domain-fn-args.js
cd0c437 
Fixes: nodejs#50571
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. domain Issues and PRs related to the domain subsystem. labels Jan 9, 2024
@lucshi

lucshi commented Mar 1, 2024

Copy link
Copy Markdown
Author

Reason is the repetition is too small and the data variance is caused by GC activities.
After increasing the repetition, node 20 downgration is fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas reviewed Mar 1, 2024
View reviewed changes

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the original intention of the benchmark case was to verify the performance of fn.call between the size of the sliced argument array: 8c69d7b.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread benchmark/domain/domain-fn-args.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Lei Shi @legendecas
Update benchmark/domain/domain-fn-args.js
2cb0215 
Co-authored-by: Chengzhong Wu <[email protected]>
legendecas
legendecas approved these changes Mar 4, 2024
View reviewed changes
@legendecas legendecas added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Mar 4, 2024
UlisesGascon
UlisesGascon approved these changes Mar 4, 2024
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 4, 2024
@nodejs-github-bot
nodejs-github-bot merged commit fde5534 into nodejs:main Mar 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2024

Copy link
Copy Markdown
Collaborator

Landed in fde5534
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lucshi
lucshi deleted the benchmark/domain/domain-fn-args.js branch March 5, 2024 01:20
targos pushed a commit that referenced this pull request Mar 7, 2024
Lei Shi @targos
benchmark: update iterations of benchmark/domain/domain-fn-args.js
625c9e0 
Fixes: #50571
PR-URL: #51408
Reviewed-By: Chengzhong Wu <[email protected]>
@targos targos mentioned this pull request Mar 7, 2024
v21.7.1 release proposal #52002
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Lei Shi @richardlau
benchmark: update iterations of benchmark/domain/domain-fn-args.js
350e9fe 
Fixes: #50571
PR-URL: #51408
Reviewed-By: Chengzhong Wu <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. domain Issues and PRs related to the domain subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lucshi @nodejs-github-bot @UlisesGascon @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.