GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: update iterations of benchmark/async_hooks/async-local- by lucshi · Pull Request #51420 · nodejs/node

Conversation

@lucshi

@lucshi lucshi commented Jan 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

storage-getstore-nested-resources.js

Before applying this PR, the real logic code of "aync hooks" is not measured accurately.
After increasing the iteration value, the test case behavior made sense.

<style> </style>
    after PR before PR benefit
async_hooks/async-local-storage-getstore-nested-resources.js resourceCount=10: 247429210.5 12782754.53 1936%
async_hooks/async-local-storage-getstore-nested-resources.js resourceCount=100: 241176206.7 12875431.49 1873%
async_hooks/async-local-storage-getstore-nested-resources.js resourceCount=1000: 265273098.7 16031987.02 1655%

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. labels Jan 10, 2024
@lucshi

lucshi commented Mar 1, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

benchmark@benchmark-S2600WFT: v16.20.2/bin/node benchmark/async_hooks/async-local-storage-getstore-nested-resources.js

async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=10: 21,332,514.164789405
async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=100: 20,428,967.458697733
async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=1000: 19,337,123.4095216

benchmark@benchmark-S2600WFT: v20.10.0/bin/node  benchmark/async_hooks/async-local-storage-getstore-nested-resources.js
async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=10: 13,379,304.62402147
async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=100: 13,310,421.660847794
async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=1000: 13,387,149.67502694

compared with node16, node21 performance downgraded by about 40%. Root cause is repetition is too small and only occupies about 1% of scoring period while 99% is occupied by GC. When the repetition is enlarged a lot, node21 downgration was fixed.

benchmark@benchmark-S2600WFT:~/luc/node_new$ /home/benchmark/.nvm/versions/node/v20.10.0/bin/node  benchmark/async_hooks/async-local-storage-getstore-nested-resources.js
async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=10: 186,648,648.85043097
async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=100: 196,515,698.066993
async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=1000: 200,298,043.4887112

benchmark@benchmark-S2600WFT:~/luc/node_new$ /home/benchmark/.nvm/versions/node/v16.20.2/bin/node  benchmark/async_hooks/async-local-storage-getstore-nested-resources.js                                           async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=10: 172,352,994.0989782
async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=100: 175,277,771.4483027
async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=1000: 164,489,213.29086003
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas approved these changes Mar 1, 2024
View reviewed changes
@legendecas

legendecas commented Mar 1, 2024

Copy link
Copy Markdown
Member

Would you mind rebasing on top of the main branch? One of the GitHub actions failed but I can not restart it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lucshi

lucshi commented Mar 1, 2024

Copy link
Copy Markdown
Author

sure I will rebase
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Lei Shi
benchmark: update iterations of benchmark/async_hooks/async-local-
13b615c 
storage-getstore-nested-resources.js

Fixes: nodejs#50571
@lucshi
lucshi force-pushed the async_hooks/async-local-storage-getstore-nested-resources.js branch from 5156af6 to 13b615c Compare March 1, 2024 13:25
legendecas
legendecas approved these changes Mar 4, 2024
View reviewed changes
@legendecas legendecas added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 4, 2024
UlisesGascon
UlisesGascon approved these changes Mar 4, 2024
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 4, 2024
@nodejs-github-bot
nodejs-github-bot merged commit bf4a63e into nodejs:main Mar 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2024

Copy link
Copy Markdown
Collaborator

Landed in bf4a63e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lucshi
lucshi deleted the async_hooks/async-local-storage-getstore-nested-resources.js branch March 5, 2024 01:19
targos pushed a commit that referenced this pull request Mar 7, 2024
Lei Shi @targos
benchmark: update iterations of benchmark/async_hooks/async-local-
0dfe810 
storage-getstore-nested-resources.js

Fixes: #50571
PR-URL: #51420
Reviewed-By: Chengzhong Wu <[email protected]>
@targos targos mentioned this pull request Mar 7, 2024
v21.7.1 release proposal #52002
Merged
@JaeMcCray201241343 JaeMcCray201241343 mentioned this pull request Mar 9, 2024
async nodejs WICG/ua-client-hints#361
Closed
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Lei Shi @richardlau
benchmark: update iterations of benchmark/async_hooks/async-local-
029ca98 
storage-getstore-nested-resources.js

Fixes: #50571
PR-URL: #51420
Reviewed-By: Chengzhong Wu <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lucshi @legendecas @nodejs-github-bot @UlisesGascon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.