GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — repl: fix `NO_COLORS` env var is ignored by MoLow · Pull Request #51568 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Jan 26, 2024

Copy link
Copy Markdown
Member

refs: #48034 (comment)

the logic in options.useColors = shouldColorize(options.output) || process.env.NODE_DISABLE_COLORS === undefined; indroduced this bug since shouldColorize already checks NODE_DISABLE_COLORS among other env vars that disable colors: NO_COLOR and TERM === 'dumb'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@MoLow
repl: fix NO_COLORS env var is ignored
90e0a07
@MoLow
MoLow requested a review from addaleax January 26, 2024 08:39
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Jan 26, 2024
benjamingr
benjamingr approved these changes Jan 26, 2024
View reviewed changes
BridgeAR
BridgeAR approved these changes Jan 26, 2024
View reviewed changes
Comment thread test/parallel/test-repl-options.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 26, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 26, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56928/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Jan 26, 2024
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
lpinca
lpinca approved these changes Jan 26, 2024
View reviewed changes
@anonrig

anonrig commented Jan 27, 2024

Copy link
Copy Markdown
Member

Can we add a test, so we don't regress?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow

MoLow commented Jan 27, 2024

Copy link
Copy Markdown
Member Author

Can we add a test, so we don't regress?

there were already existing tests that needed fixing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56935/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56945/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56971/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Jan 31, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 31, 2024
@nodejs-github-bot
nodejs-github-bot merged commit a501315 into nodejs:main Jan 31, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2024

Copy link
Copy Markdown
Collaborator

Landed in a501315
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow deleted the fix-no-colors branch January 31, 2024 08:35
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Jan 31, 2024
Create a new pull request by comparing changes across two branches. javascript-indonesias/node#965
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
@MoLow @rdw-msft
repl: fix NO_COLORS env var is ignored
ddd157b 
PR-URL: nodejs#51568
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
@MoLow @targos
repl: fix NO_COLORS env var is ignored
3e579ab 
PR-URL: #51568
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
v21.7.0 proposal #51932
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@MoLow @richardlau
repl: fix NO_COLORS env var is ignored
f94336f 
PR-URL: #51568
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
@richardlau richardlau mentioned this pull request Jan 7, 2025
NO_COLOR not an alias for NODE_DISABLE_COLORS in v18 #56509
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes
@addaleax addaleax addaleax approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@MoLow @nodejs-github-bot @anonrig @addaleax @benjamingr @lpinca @BridgeAR
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.