GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — report: add `--report-exclude-network` option by Ethan-Arrowood · Pull Request #51645 · nodejs/node

Conversation

Ethan-Arrowood commented Feb 2, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

New option --report-exclude-network, also available as report.excludeNetwork, enables the user to exclude networking interfaces in their diagnostic report. On some systems, this can cause the report to take minutes to generate so this option can be used to optimize that.

Fixes: #46060

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

styfle reacted with rocket emoji

All reactions

🚀 1 reaction

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci PRs that need a full CI run. labels

Feb 2, 2024

Ethan-Arrowood requested a review from joyeecheung

February 2, 2024 03:17

Ethan-Arrowood force-pushed the fix/process-getreport branch from 8b03a57 to 0f094cb Compare

February 2, 2024 03:21

Ethan-Arrowood marked this pull request as ready for review

February 2, 2024 03:21

Ethan-Arrowood commented Feb 2, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

I'm not used to the tests not being in either sequential or parallel. I add some more tests that verify the header.networkInterfaces is missing when this option is set (either by CLI or configuration). I used new test syntax and what not so hopefully that still works in the test/report/ directory.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig self-requested a review

February 2, 2024 03:39

Ethan-Arrowood force-pushed the fix/process-getreport branch 2 times, most recently from 8341898 to 1f12672 Compare

February 2, 2024 04:18

Ethan-Arrowood added the report Issues and PRs related to Node.js diagnostic reports. label

Feb 2, 2024

joyeecheung reviewed

Feb 2, 2024

View reviewed changes

Comment thread

src/node_options.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_report_module.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

styfle reviewed

Feb 2, 2024

View reviewed changes

Comment thread

test/report/test-report-disable-network.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

anonrig reviewed

Feb 2, 2024

View reviewed changes

Comment thread

doc/api/report.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

lib/internal/process/report.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_report.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_report.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/node_report.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/report/test-report-config.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Ethan-Arrowood changed the title ~~report: add --report-disable-network option~~ report: add --report-network-disabled option

Feb 5, 2024

Ethan-Arrowood requested review from anonrig, joyeecheung and styfle

February 5, 2024 18:29

Ethan-Arrowood force-pushed the fix/process-getreport branch from 43125e2 to 2d5fb4e Compare

February 5, 2024 20:21

Ethan-Arrowood force-pushed the fix/process-getreport branch from 2d5fb4e to 25be48a Compare

February 5, 2024 20:28

Ethan-Arrowood force-pushed the fix/process-getreport branch from 0ca3be5 to e485abb Compare

February 5, 2024 20:36

anonrig approved these changes

Feb 5, 2024

View reviewed changes

anonrig added semver-minor

PRs that contain new features and should be released in the next minor version.

notable-change PRs with changes that should be highlighted in changelogs. labels

Feb 5, 2024

github-actions Bot commented Feb 5, 2024

Copy link

Copy Markdown

Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ethan-Arrowood commented Feb 5, 2024

Copy link

Copy Markdown

Contributor Author

@anonrig I'm getting a segmentation fault now (after I made the change Joyee recommended). Trying to debug but this is hard

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ethan-Arrowood commented

Feb 6, 2024

View reviewed changes

Comment thread

src/node_report_module.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

richardlau reviewed

Feb 6, 2024

View reviewed changes

Comment thread

doc/api/report.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Feb 15, 2024

nodejs-github-bot commented Feb 15, 2024

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/51645
✔  Done loading data for nodejs/node/pull/51645
----------------------------------- PR info ------------------------------------
Title      report: add `--report-exclude-network` option (#51645)
Author     Ethan Arrowood  (@Ethan-Arrowood)
Branch     Ethan-Arrowood:fix/process-getreport -> nodejs:main
Labels     c++, semver-minor, lib / src, notable-change, needs-ci, report
Commits    1
 - report: add `--report-exclude-network` option
Committers 1
 - Ethan Arrowood 
PR-URL: https://github.com/nodejs/node/pull/51645
Fixes: https://github.com/nodejs/node/issues/46060
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51645
Fixes: https://github.com/nodejs/node/issues/46060
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - report: add `--report-exclude-network` option
   ℹ  This PR was created on Fri, 02 Feb 2024 03:17:12 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1864004600
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1881176781
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-02-15T15:18:08Z: https://ci.nodejs.org/job/node-test-pull-request/57100/
- Querying data for job/node-test-pull-request/57100/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/7923747889

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Feb 15, 2024

nodejs-github-bot commented Feb 16, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57119/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 16, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57136/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 17, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57154/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 17, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57155/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          report: add --report-exclude-network option

67ca735

New option `--report-exclude-network`, also available as
`report.excludeNetwork`, enables the user to exclude
networking interfaces in their diagnostic report.
On some systems, this can cause the report to take minutes
to generate so this option can be used to optimize that.

Fixes: nodejs#46060

PR-URL: nodejs#51645

Co-authored-by: Joyee Cheung <[email protected]>

Ethan-Arrowood force-pushed the fix/process-getreport branch from 99d022c to 67ca735 Compare

February 21, 2024 17:13

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 21, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 21, 2024

nodejs-github-bot commented Feb 21, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57259/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ethan-Arrowood mentioned this pull request

Feb 22, 2024

CI flakiness becomes unmanageable #51819

Closed

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 23, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 23, 2024

nodejs-github-bot commented Feb 23, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57345/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Feb 27, 2024

nodejs-github-bot commented Feb 27, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57456/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 29, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57507/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ethan-Arrowood commented Mar 1, 2024

Copy link

Copy Markdown

Contributor Author

If you like at all of the CI runs for this PR it has only failed flaky tests. There is nothing failing consistently, so I believe this is safe to land

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Mar 1, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57536/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Mar 1, 2024

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/51645
✔  Done loading data for nodejs/node/pull/51645
----------------------------------- PR info ------------------------------------
Title      report: add `--report-exclude-network` option (#51645)
Author     Ethan Arrowood  (@Ethan-Arrowood)
Branch     Ethan-Arrowood:fix/process-getreport -> nodejs:main
Labels     c++, semver-minor, lib / src, notable-change, needs-ci, report
Commits    1
 - report: add `--report-exclude-network` option
Committers 1
 - Ethan Arrowood 
PR-URL: https://github.com/nodejs/node/pull/51645
Fixes: https://github.com/nodejs/node/issues/46060
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51645
Fixes: https://github.com/nodejs/node/issues/46060
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - report: add `--report-exclude-network` option
   ℹ  This PR was created on Fri, 02 Feb 2024 03:17:12 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1864004600
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1881176781
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-03-01T16:27:31Z: https://ci.nodejs.org/job/node-test-pull-request/57536/
- Querying data for job/node-test-pull-request/57536/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8114994573

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ethan-Arrowood commented Mar 1, 2024

Copy link

Copy Markdown

Contributor Author

Commit-queue failed because I pushed a rebase after latest reviews. Can someone reapprove this please? @anonrig @joyeecheung

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung approved these changes

Mar 1, 2024

View reviewed changes

nodejs-github-bot commented Mar 1, 2024

Copy link

Copy Markdown

Collaborator

Landed in 009665f

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

styfle mentioned this pull request

Mar 1, 2024

fix: improve performance of getReport() lovell/detect-libc#21

Merged

dstaley mentioned this pull request

Mar 18, 2024

[BUG] process.report.getReport() is very very slow on win32 npm/npm-install-checks#95

Closed

1 task done

RafaelGSS mentioned this pull request

Apr 15, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

marco-ippolito mentioned this pull request

May 2, 2024

v20.13.0 proposal #52793

Merged

coderabbitai Bot mentioned this pull request

Aug 4, 2026

fix(npm): select the Linux platform package by libc, not manifest order kjanat/runner#108

Merged

1 task done

Reviewers

joyeecheung

joyeecheung approved these changes

styfle

Awaiting requested review from styfle

richardlau

Awaiting requested review from richardlau

anonrig

Awaiting requested review from anonrig

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci

PRs that need a full CI run.

notable-change

PRs with changes that should be highlighted in changelogs.

report

Issues and PRs related to Node.js diagnostic reports.

semver-minor

PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

process.report.getReport(); is potentially very slow

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Ethan-Arrowood commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ethan-Arrowood commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 5, 2024

Uh oh!

Ethan-Arrowood commented Feb 5, 2024

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 15, 2024

Uh oh!

nodejs-github-bot commented Feb 16, 2024

Uh oh!

nodejs-github-bot commented Feb 16, 2024

Uh oh!

nodejs-github-bot commented Feb 17, 2024

Uh oh!

nodejs-github-bot commented Feb 17, 2024

Uh oh!

nodejs-github-bot commented Feb 21, 2024

Uh oh!

nodejs-github-bot commented Feb 23, 2024

Uh oh!

nodejs-github-bot commented Feb 27, 2024

Uh oh!

nodejs-github-bot commented Feb 29, 2024

Uh oh!

Ethan-Arrowood commented Mar 1, 2024

Uh oh!

nodejs-github-bot commented Mar 1, 2024

Uh oh!

nodejs-github-bot commented Mar 1, 2024

Uh oh!

Ethan-Arrowood commented Mar 1, 2024

Uh oh!

nodejs-github-bot commented Mar 1, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Ethan-Arrowood commented Feb 2, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Ethan-Arrowood commented Feb 2, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.