GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix dns.lookup family `0` and `all` description by domdomegg · Pull Request #51653 · nodejs/node

Conversation

@domdomegg

@domdomegg domdomegg commented Feb 3, 2024 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes: #51482

Also see #51483, #51517

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to Node.js documentation. labels Feb 3, 2024
@domdomegg domdomegg changed the title doc: fix dns.lookup family 0 and all description doc: fix dns.lookup family 0 and all description Feb 3, 2024
@aduh95
aduh95 requested a review from ShogunPanda February 3, 2024 17:10
ShogunPanda
ShogunPanda approved these changes Feb 5, 2024
View reviewed changes

@ShogunPanda ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
domdomegg added 3 commits May 11, 2024 18:16
@domdomegg @aduh95
doc: fix dns.lookup family 0 and all description
952ae65 
Fixes nodejs#51482
@domdomegg @aduh95
Fix other mentions
b1464a3
@domdomegg @aduh95
Fix wrapping line length
8d84574
@aduh95
aduh95 force-pushed the fix-51482 branch from 234b4bc to 8d84574 Compare May 11, 2024 15:16
aduh95
aduh95 approved these changes May 11, 2024
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 11, 2024
@aduh95
aduh95 merged commit 6e07a76 into nodejs:main May 11, 2024
@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

Landed in 6e07a76
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 12, 2024
@domdomegg @targos
doc: fix dns.lookup family 0 and all descriptions
030f56e 
PR-URL: #51653
Fixes: #51482
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@domdomegg @marco-ippolito
doc: fix dns.lookup family 0 and all descriptions
3aa3337 
PR-URL: #51653
Fixes: #51482
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@domdomegg @soophoo
doc: fix dns.lookup family 0 and all descriptions
cc2f5b9 
PR-URL: nodejs#51653
Fixes: nodejs#51482
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: dns docs for family = 0 and all = true is potentially misleading

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@domdomegg @nodejs-github-bot @aduh95 @ShogunPanda
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.