GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: move non-present deps down the list by AdamMajer · Pull Request #51746 · nodejs/node

Conversation

@AdamMajer

@AdamMajer AdamMajer commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

In previous version of this fix, I've simply added a check if the tested tool is available or not. Unfortuntelly, this fails when only the first tool is to be run as part of the test-benchmark-misc, and it doesn't exist.

benchmark/test-benchmark-misc
...
AssertionError [ERR_ASSERTION]: benchmark file not running exactly one configuration in test:
...
misc/startup-cli-version.js
...

The solution is to move the tool that is not present in a tarball down the list.

Fixes: #51146
Refs: #50684

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. label Feb 13, 2024
@AdamMajer
AdamMajer force-pushed the benchmark-fixes branch 2 times, most recently from 396f5e4 to 893ac74 Compare February 13, 2024 12:44
richardlau
richardlau approved these changes Feb 13, 2024
View reviewed changes
joyeecheung
joyeecheung reviewed Feb 13, 2024
View reviewed changes
Comment thread benchmark/misc/startup-cli-version.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AdamMajer
benchmark: move non-present deps down the list
91bba09 
In previous version of this fix, I've simply added a check if the tested
tool is available or not. Unfortuntelly, this fails when only the first
tool is to be run as part of the test-benchmark-misc, and it doesn't
exist.

benchmark/test-benchmark-misc
...
AssertionError [ERR_ASSERTION]: benchmark file not running exactly one
configuration in test:
...
misc/startup-cli-version.js
...

One solution is to check if the cli tool is actually available before
using it in a benchmark

Refs: nodejs#51146
@AdamMajer
AdamMajer force-pushed the benchmark-fixes branch from 893ac74 to 91bba09 Compare February 14, 2024 12:36
@AdamMajer
AdamMajer requested a review from joyeecheung February 14, 2024 12:43
lpinca
lpinca approved these changes Feb 14, 2024
View reviewed changes
marco-ippolito
marco-ippolito approved these changes Feb 15, 2024
View reviewed changes
joyeecheung
joyeecheung approved these changes Feb 29, 2024
View reviewed changes
marco-ippolito
marco-ippolito approved these changes Feb 29, 2024
View reviewed changes
@joyeecheung joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 1, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Mar 1, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51746
✔  Done loading data for nodejs/node/pull/51746
----------------------------------- PR info ------------------------------------
Title      benchmark: move non-present deps down the list (#51746)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     AdamMajer:benchmark-fixes -> nodejs:main
Labels     benchmark
Commits    1
 - benchmark: move non-present deps down the list
Committers 1
 - Adam Majer 
PR-URL: https://github.com/nodejs/node/pull/51746
Fixes: https://github.com/nodejs/node/pull/51146
Refs: https://github.com/nodejs/node/pull/50684
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Marco Ippolito 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51746
Fixes: https://github.com/nodejs/node/pull/51146
Refs: https://github.com/nodejs/node/pull/50684
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Marco Ippolito 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 13 Feb 2024 12:31:27 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/51746#pullrequestreview-1877961858
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51746#pullrequestreview-1881265306
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51746#pullrequestreview-1909418797
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51746#pullrequestreview-1909400852
   ✘  GitHub CI is still running
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/8113019460
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit b1515c7 into nodejs:main May 11, 2024
@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

Landed in b1515c7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 11, 2024
@AdamMajer @targos
benchmark: filter non-present deps from start-cli-version
2c7d7ca 
PR-URL: #51746
Refs: #51146
Refs: #50684
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@AdamMajer @marco-ippolito
benchmark: filter non-present deps from start-cli-version
184cfe5 
PR-URL: #51746
Refs: #51146
Refs: #50684
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@AdamMajer @soophoo
benchmark: filter non-present deps from start-cli-version
3910b40 
PR-URL: nodejs#51746
Refs: nodejs#51146
Refs: nodejs#50684
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@richardlau richardlau richardlau approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@AdamMajer @nodejs-github-bot @aduh95 @lpinca @joyeecheung @richardlau @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.