GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Revert "build: fix warning in cares under GN build" by lpinca · Pull Request #51865 · nodejs/node

Conversation

lpinca commented Feb 24, 2024

Copy link

Copy Markdown

Member

Depends on #51846.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

nodejs-github-bot commented Feb 24, 2024

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/net
@nodejs/security-wg

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added cares

Issues and PRs related to the c-ares dependency or the cares_wrap binding.

dependencies

PRs that add, update, or configure Node.js dependencies.

needs-ci PRs that need a full CI run. labels

Feb 24, 2024

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 25, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 25, 2024

nodejs-github-bot commented Feb 25, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57396/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 25, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57399/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca force-pushed the revert/f22802ceb89a branch from 2f66f1c to faedc96 Compare

February 25, 2024 13:57


          Revert "build: fix warning in cares under GN build"

92156e8

This reverts commit f22802c.

lpinca force-pushed the revert/f22802ceb89a branch from faedc96 to 92156e8 Compare

February 25, 2024 13:59

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 25, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 25, 2024

nodejs-github-bot commented Feb 25, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57404/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 25, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57406/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

H4ad approved these changes

Feb 25, 2024

View reviewed changes

lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label

Mar 2, 2024

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Mar 2, 2024

nodejs-github-bot commented Mar 2, 2024

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/51865
✔  Done loading data for nodejs/node/pull/51865
----------------------------------- PR info ------------------------------------
Title      Revert "build: fix warning in cares under GN build" (#51865)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     lpinca:revert/f22802ceb89a -> nodejs:main
Labels     cares, needs-ci, dependencies
Commits    1
 - Revert "build: fix warning in cares under GN build"
Committers 1
 - Luigi Pinca 
PR-URL: https://github.com/nodejs/node/pull/51865
Reviewed-By: Vinícius Lourenço Claro Cardoso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51865
Reviewed-By: Vinícius Lourenço Claro Cardoso 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 24 Feb 2024 19:24:30 GMT
   ✔  Approvals: 1
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51865#pullrequestreview-1899748051
   ✘  This PR needs to wait 7 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-02-25T16:48:31Z: https://ci.nodejs.org/job/node-test-pull-request/57406/
- Querying data for job/node-test-pull-request/57406/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8122507139

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label

Mar 3, 2024

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Mar 3, 2024

nodejs-github-bot merged commit 3a456c6 into nodejs:main

Mar 3, 2024

nodejs-github-bot commented Mar 3, 2024

Copy link

Copy Markdown

Collaborator

Landed in 3a456c6

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca deleted the revert/f22802ceb89a branch

March 3, 2024 06:30

targos pushed a commit that referenced this pull request

Mar 7, 2024


          Revert "build: fix warning in cares under GN build"

9617adc

This reverts commit f22802c.

PR-URL: #51865
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

targos mentioned this pull request

Mar 7, 2024

v21.7.1 release proposal #52002

Merged

richardlau pushed a commit that referenced this pull request

Mar 25, 2024


          Revert "build: fix warning in cares under GN build"

0a7419b

This reverts commit f22802c.

PR-URL: #51865
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>

richardlau mentioned this pull request

Mar 25, 2024

v20.12.0 proposal #52212

Merged

Reviewers

H4ad

H4ad approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cares

Issues and PRs related to the c-ares dependency or the cares_wrap binding.

commit-queue-failed

PRs whose Commit Queue landing failed and need manual intervention before retrying.

dependencies

PRs that add, update, or configure Node.js dependencies.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.