GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — build: fix arm64 host cross-compilation in GN by zcbenz · Pull Request #51903 · nodejs/node

Conversation

zcbenz commented Feb 28, 2024

Copy link

Copy Markdown

Contributor

Should use current_cpu instead of target_cpu in GN build files, otherwise the host build may use wrong configs when doing cross-compilation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 28, 2024

nodejs-github-bot commented Feb 28, 2024

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/security-wg

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added dependencies

PRs that add, update, or configure Node.js dependencies.

needs-ci

PRs that need a full CI run.

openssl Issues and PRs related to the OpenSSL dependency. labels

Feb 28, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 28, 2024

nodejs-github-bot commented Feb 28, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57482/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos approved these changes

Feb 28, 2024

View reviewed changes

lpinca approved these changes

Feb 28, 2024

View reviewed changes


          build: fix arm64 host cross-compilation in GN

6942d29

Should use `current_cpu` instead of `target_cpu` in GN build files,
otherwise the host build may use wrong configs when doing cross
compilation.

zcbenz force-pushed the fix-cross-compilation branch from 2af5430 to 6942d29 Compare

March 5, 2024 00:29

zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Mar 5, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

There was an error while loading. Please reload this page.

zcbenz added commit-queue

PRs queued for automated landing through the Commit Queue.

commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels

Mar 6, 2024

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Mar 6, 2024

nodejs-github-bot commented Mar 6, 2024

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/51903
✔  Done loading data for nodejs/node/pull/51903
----------------------------------- PR info ------------------------------------
Title      build: fix arm64 host cross-compilation in GN (#51903)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     zcbenz:fix-cross-compilation -> nodejs:main
Labels     openssl, needs-ci, dependencies, commit-queue-squash
Commits    1
 - build: fix arm64 host cross-compilation in GN
Committers 1
 - Cheng Zhao 
PR-URL: https://github.com/nodejs/node/pull/51903
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51903
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - build: fix arm64 host cross-compilation in GN
   ℹ  This PR was created on Wed, 28 Feb 2024 02:36:17 GMT
   ✔  Approvals: 2
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/51903#pullrequestreview-1905393209
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51903#pullrequestreview-1907326923
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-03-05T23:36:22Z: https://ci.nodejs.org/job/node-test-pull-request/57601/
- Querying data for job/node-test-pull-request/57601/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/8165436949

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zcbenz added a commit that referenced this pull request

Mar 6, 2024


          build: fix arm64 host cross-compilation in GN

384fd17

Should use `current_cpu` instead of `target_cpu` in GN build files,
otherwise the host build may use wrong configs when doing cross
compilation.

PR-URL: #51903
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

zcbenz commented Mar 6, 2024

Copy link

Copy Markdown

Contributor Author

Landed in 384fd17

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zcbenz closed this

Mar 6, 2024

zcbenz deleted the fix-cross-compilation branch

March 6, 2024 02:12

targos pushed a commit that referenced this pull request

Mar 7, 2024


          build: fix arm64 host cross-compilation in GN

7ff3551

Should use `current_cpu` instead of `target_cpu` in GN build files,
otherwise the host build may use wrong configs when doing cross
compilation.

PR-URL: #51903
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

targos mentioned this pull request

Mar 7, 2024

v21.7.1 release proposal #52002

Merged

richardlau pushed a commit that referenced this pull request

Mar 25, 2024


          build: fix arm64 host cross-compilation in GN

51ea5b6

Should use `current_cpu` instead of `target_cpu` in GN build files,
otherwise the host build may use wrong configs when doing cross
compilation.

PR-URL: #51903
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

richardlau mentioned this pull request

Mar 25, 2024

v20.12.0 proposal #52212

Merged

Reviewers

lpinca

lpinca approved these changes

+1 more reviewer

targos

targos approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-failed

PRs whose Commit Queue landing failed and need manual intervention before retrying.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

dependencies

PRs that add, update, or configure Node.js dependencies.

needs-ci

PRs that need a full CI run.

openssl

Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.