GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] deps: update icu to 74.2 by targos · Pull Request #51973 · nodejs/node

Conversation

@targos

@targos targos commented Mar 5, 2024

Copy link
Copy Markdown
Member
  • deps: update icu to 74.1
  • deps: update timezone to 2023d
  • tools: fix update-icu.sh
  • deps: update icu to 74.2
  • deps: update timezone to 2024a

Refs: #51933

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
nodejs-github-bot and others added 5 commits March 5, 2024 15:53
@nodejs-github-bot @targos
deps: update icu to 74.1
7cca463
PR-URL: nodejs#50515
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
@nodejs-github-bot @targos
deps: update timezone to 2023d
ab1114f
PR-URL: nodejs#51461
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos
tools: fix update-icu.sh
22980b8
The name of the sources MD5 file has changed.

Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: nodejs#51723
Refs: nodejs#51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos
deps: update icu to 74.2
3889bde
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: nodejs#51723
Refs: nodejs#51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos
deps: update timezone to 2024a
a92d454
PR-URL: nodejs#51723
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
Refs: nodejs#51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. v18.x labels Mar 5, 2024
@targos targos mentioned this pull request Mar 5, 2024
Release a patch release for 2024a tzdata #51933
Closed
richardlau
richardlau approved these changes Mar 5, 2024
View reviewed changes
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 5, 2024
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Mar 5, 2024
@github-actions

github-actions Bot commented Mar 5, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507
  ReadableStream
  ^

ReferenceError: ReadableStream is not defined
at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/response.js:507:3)
at Module._compile (node:internal/modules/cjs/loader:1198:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
at Module.load (node:internal/modules/cjs/loader:1076:32)
at Function.Module._load (node:internal/modules/cjs/loader:911:12)
at Module.require (node:internal/modules/cjs/loader:1100:19)
at require (node:internal/modules/cjs/helpers:119:18)
at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/undici/lib/web/fetch/index.js:11:5)
at Module._compile (node:internal/modules/cjs/loader:1198:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)

https://github.com/nodejs/node/actions/runs/8158770866

richardlau reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Mar 5, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 5, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau richardlau linked an issue Mar 10, 2024 that may be closed by this pull request
Update node 18 to use ICU4C 74 #51556
Closed
lpinca
lpinca approved these changes Mar 10, 2024
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 15, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57767/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau pushed a commit that referenced this pull request Mar 18, 2024
@nodejs-github-bot @richardlau
deps: update icu to 74.1
2a2bf57
PR-URL: #50515
Backport-PR-URL: #51973
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 18, 2024
@nodejs-github-bot @richardlau
deps: update timezone to 2023d
90c73d2
PR-URL: #51461
Backport-PR-URL: #51973
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 18, 2024
@targos @richardlau
tools: fix update-icu.sh
3184bef
The name of the sources MD5 file has changed.

Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: #51723
Backport-PR-URL: #51973
Refs: #51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 18, 2024
@targos @richardlau
deps: update icu to 74.2
f9b229e
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: #51723
Backport-PR-URL: #51973
Refs: #51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this pull request Mar 18, 2024
@targos @richardlau
deps: update timezone to 2024a
68fd751
PR-URL: #51723
Backport-PR-URL: #51973
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
Refs: #51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #51933
@richardlau

richardlau commented Mar 18, 2024

Copy link
Copy Markdown
Member

Landed in fe66e9d...68fd751.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau closed this Mar 18, 2024
@targos
targos deleted the update-icu-v18.x branch March 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update node 18 to use ICU4C 74

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@targos @nodejs-github-bot @richardlau @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.