GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v20.x] backport libuv wtf-8 decoding fix by richardlau · Pull Request #51976 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Mar 5, 2024

Copy link
Copy Markdown
Member

This backports libuv/libuv@d09441c to Node.js 20 to fix a long standing regression in the way filenames are handled on Windows. On Node.js 21 this was fixed by the update to libuv 1.47.0, but that version cannot be backported to Node.js 20 because libuv have dropped support for macOS <11 and we target macOS 10.15 for Node.js 20.

Refs: #48673

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
richardlau and others added 2 commits March 5, 2024 14:02
@richardlau
deps: cherry-pick libuv/libuv@d09441c
c623d8e 
Original commit message:

    fs: fix WTF-8 decoding issue (nodejs#4092)

    We forgot to mask off the high bits from the first byte, so we ended up
    always failing the subsequent range check.

    Refs: libuv/libuv#2970
    Fixes: nodejs#48673
@mertcanaltin @richardlau
test: test surrogate pair filenames on windows
d540f55 
PR-URL: nodejs#51800
Fixes: nodejs#51789
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. v20.x labels Mar 5, 2024
RafaelGSS
RafaelGSS approved these changes Mar 5, 2024
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 5, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 5, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57593/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Mar 5, 2024
View reviewed changes
marco-ippolito
marco-ippolito approved these changes Mar 5, 2024
View reviewed changes
santigimeno
santigimeno approved these changes Mar 5, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57600/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@santigimeno santigimeno mentioned this pull request Mar 6, 2024
Test failure with 1.48.0 on OSX x86 libuv/libuv#4332
Closed
StefanStojanovic
StefanStojanovic approved these changes Mar 9, 2024
View reviewed changes
UlisesGascon
UlisesGascon approved these changes Mar 10, 2024
View reviewed changes

@UlisesGascon UlisesGascon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau richardlau mentioned this pull request Mar 12, 2024
Add tests for filenames with surrogate pairs on Windows #51789
Closed
mertcanaltin
mertcanaltin approved these changes Mar 14, 2024
View reviewed changes

@mertcanaltin mertcanaltin left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlttiRi AlttiRi mentioned this pull request Mar 14, 2024
(Windows) FS can not handle certain characters in file name #48673
Closed
richardlau added a commit that referenced this pull request Mar 15, 2024
@richardlau
deps: cherry-pick libuv/libuv@d09441c
cb49f31 
Original commit message:

    fs: fix WTF-8 decoding issue (#4092)

    We forgot to mask off the high bits from the first byte, so we ended up
    always failing the subsequent range check.

    Refs: libuv/libuv#2970
    Fixes: #48673

PR-URL: #51976
Refs: #48673
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 15, 2024
@mertcanaltin @richardlau
test: test surrogate pair filenames on windows
e8f5735 
PR-URL: #51800
Backport-PR-URL: #51976
Fixes: #51789
Refs: #48673
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@richardlau

richardlau commented Mar 15, 2024

Copy link
Copy Markdown
Member Author

Landed in ea50540...e8f5735.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau closed this Mar 15, 2024
@richardlau
richardlau deleted the surrogate branch March 15, 2024 17:23
@richardlau

richardlau commented Mar 15, 2024

Copy link
Copy Markdown
Member Author

FYI I'm aiming to do a Node.js 20 release around 26 March 2024 which will include this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santigimeno santigimeno santigimeno approved these changes
@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@mertcanaltin mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@richardlau @nodejs-github-bot @santigimeno @lpinca @UlisesGascon @StefanStojanovic @RafaelGSS @marco-ippolito @mertcanaltin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.