GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — [v20.x] deps: V8: remove references to non-existent flags by richardlau · Pull Request #52256 · nodejs/node Conversation
Member
#49703 cherry-picked a commit from upstream V8 which references some maglev-related flags that are not present in the version of V8 in Node.js 20. V8 CI on x64 is currently broken, e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/5892/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console 16:38:36 ../../src/flags/flags.cc:590:33: error: no member named 'maglev_deopt_data_on_background' in 'v8::internal::FlagValues' 16:38:36 flag.PointsTo(&v8_flags.maglev_deopt_data_on_background) || 16:38:36 ~~~~~~~~ ^ 16:38:36 ../../src/flags/flags.cc:591:33: error: no member named 'maglev_build_code_on_background' in 'v8::internal::FlagValues' 16:38:36 flag.PointsTo(&v8_flags.maglev_build_code_on_background) || 16:38:36 ~~~~~~~~ ^ 16:38:36 2 errors generated. This comes from #49703 which went out in Node.js 20.8.0 and was presumably missed because the x64 V8 CI has been unreliable due to networking issues on the machine. The V8 CI has been moved onto new x64 machines, which have revealed this compilation failure. (Other release lines successfully compile but are failing perf-related tests.) Other platforms tested in the V8 CI, Linux on ppc64le and s390x, do not enable maglev so didn't surface this. This is a fairly naive attempt to fix the compilation failure -- I don't know if there are alternate flags for the version of V8 in Node.js 20 that should be implied by
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
joyeecheung
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is just to ignore flags implied by —predictable when computing the hash of flags. If the flags are not present it’s safe to just not add code to…ignore rhem.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
lpinca
approved these changes
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
gengjiawen
approved these changes
marco-ippolito
approved these changes
RafaelGSS
approved these changes
RafaelGSS
force-pushed
the
v20.x-staging
branch
from
ae243ec to
32014f5
Compare
nodejs#49703 cherry-picked a commit from upstream V8 which references some maglev-related flags that are not present in the version of V8 in Node.js 20.
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
richardlau
added a commit
that referenced
this pull request
#49703 cherry-picked a commit from upstream V8 which references some maglev-related flags that are not present in the version of V8 in Node.js 20. PR-URL: #52256 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
|
There was an error while loading. Please reload this page.
|
Landed in ecadd63. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.