GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: call out http(s).globalAgent defaults by fahrradflucht · Pull Request #52392 · nodejs/node

Conversation

@fahrradflucht

@fahrradflucht fahrradflucht commented Apr 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Despite the http.Agent stating:

The default http.globalAgent that is used by http.request() has all of these values set to their respective defaults.

this isn't true anymore since node.js 19. Both, the http and the https globalAgent now set { keepAlive: true, scheduling: 'lifo', timeout: 5000 } as options. 'lifo' is the default anyway, but keepAlive is turned off and no timeout is set on new Agent().

Document the diverging behavior in the globalAgent sections, remove the false statement from http.Agent section, and extend the changelog to call out the timeout change as well.

Closes #48821
Closes #51115

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Apr 6, 2024
lpinca
lpinca approved these changes Apr 7, 2024
View reviewed changes
@lpinca

lpinca commented Apr 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes: #51115
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShogunPanda
ShogunPanda approved these changes Apr 7, 2024
View reviewed changes
mcollina
mcollina approved these changes Apr 7, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@fahrradflucht
doc: call out http(s).globalAgent default
4a008be 
Despite the `http.Agent` stating:

> The default `http.globalAgent` that is used by `http.request()` has
> all of these values set to their respective defaults.

this isn't true anymore since node.js 19. Both, the http as well as the
https `globalAgent` now set `{ keepAlive: true, scheduling: 'lifo',
timeout: 5000 }` as options. `'lifo'` is the default anyway, but
`keepAlive` is turned off and no `timeout` is set on `new Agent()`.

Document the diverging behaviour in the `globalAgent` sections, remove
the false statement from `http.Agent` section, and extend the changelog
to call out the timeout change as well.
@fahrradflucht
fahrradflucht force-pushed the docs/http-global-agent-defaults branch from f477d6d to 4a008be Compare April 7, 2024 08:45
@fahrradflucht

fahrradflucht commented Apr 7, 2024

Copy link
Copy Markdown
Contributor Author

Fixed the commit message. 🙄 Never make an edit without gqq. 😉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-ippolito
marco-ippolito approved these changes Apr 7, 2024
View reviewed changes
UlisesGascon
UlisesGascon approved these changes Apr 7, 2024
View reviewed changes
@fahrradflucht

fahrradflucht commented Apr 7, 2024

Copy link
Copy Markdown
Contributor Author

"lint-js-and-md" failure looks like CI flake to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Apr 8, 2024
View reviewed changes
@marco-ippolito marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 8, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 655b327 into nodejs:main Apr 8, 2024
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2024

Copy link
Copy Markdown
Collaborator

Landed in 655b327
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
2024-04-24, Version 22.0.0 (Current) #52505
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@fahrradflucht @marco-ippolito
doc: call out http(s).globalAgent default
b7f73a8 
Despite the `http.Agent` stating:

> The default `http.globalAgent` that is used by `http.request()` has
> all of these values set to their respective defaults.

this isn't true anymore since node.js 19. Both, the http as well as the
https `globalAgent` now set `{ keepAlive: true, scheduling: 'lifo',
timeout: 5000 }` as options. `'lifo'` is the default anyway, but
`keepAlive` is turned off and no `timeout` is set on `new Agent()`.

Document the diverging behaviour in the `globalAgent` sections, remove
the false statement from `http.Agent` section, and extend the changelog
to call out the timeout change as well.

PR-URL: #52392
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
v20.13.0 proposal #52793
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@fahrradflucht @marco-ippolito
doc: call out http(s).globalAgent default
f3f67ff 
Despite the `http.Agent` stating:

> The default `http.globalAgent` that is used by `http.request()` has
> all of these values set to their respective defaults.

this isn't true anymore since node.js 19. Both, the http as well as the
https `globalAgent` now set `{ keepAlive: true, scheduling: 'lifo',
timeout: 5000 }` as options. `'lifo'` is the default anyway, but
`keepAlive` is turned off and no `timeout` is set on `new Agent()`.

Document the diverging behaviour in the `globalAgent` sections, remove
the false statement from `http.Agent` section, and extend the changelog
to call out the timeout change as well.

PR-URL: #52392
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@fahrradflucht
fahrradflucht deleted the docs/http-global-agent-defaults branch June 6, 2024 08:43
@coderabbitai coderabbitai Bot mentioned this pull request Aug 19, 2026
feat: implement turret management system with registry table, admin r… Stellar-IndigoPay/Stellar-IndigoPay#973
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@ShogunPanda ShogunPanda ShogunPanda approved these changes
@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@MoLow MoLow MoLow approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs imply that http globalAgent is created with keepAlive: false

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@fahrradflucht @nodejs-github-bot @lpinca @mcollina @ShogunPanda @UlisesGascon @MoLow @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.