GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix grammatical mistake · Pull Request #52808 · nodejs/node

Conversation

@ghost

@ghost ghost commented May 2, 2024

Copy link
Copy Markdown

Fixes a minor grammatical mistake in the description of WritableStreamDefaultController

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
codershiba
doc: fix grammatical mistake
52fe562
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label May 2, 2024
lpinca
lpinca approved these changes May 2, 2024
View reviewed changes
benjamingr
benjamingr approved these changes May 2, 2024
View reviewed changes
@benjamingr benjamingr added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 2, 2024
@github-actions

github-actions Bot commented May 2, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

daeyeon and anonrig reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daeyeon
daeyeon approved these changes May 3, 2024
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 3, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 3, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 2c55652 into nodejs:main May 3, 2024
@nodejs-github-bot

nodejs-github-bot commented May 3, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2c55652

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost
ghost deleted the patch-1 branch May 4, 2024 08:15
targos pushed a commit that referenced this pull request May 8, 2024
codershiba @targos
doc: fix grammatical mistake
0cb7cf7
PR-URL: #52808
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
targos pushed a commit that referenced this pull request May 21, 2024
codershiba @targos
doc: fix grammatical mistake
d9c5114
PR-URL: #52808
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 23, 2024
v20.14.0 proposal #53120
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
codershiba @soophoo
doc: fix grammatical mistake
bdc378b
PR-URL: nodejs#52808
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nodejs-github-bot @benjamingr @lpinca @daeyeon @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.