GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: skip v8-updates/test-linux-perf-logger by targos · Pull Request #52821 · nodejs/node

Conversation

@targos

@targos targos commented May 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs: #51308

Recent V8 CI failure: https://ci.nodejs.org/job/node-test-commit-v8-linux/5954/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 3, 2024
@targos
test: skip v8-updates/test-linux-perf-logger
18d42f0 
Refs: nodejs#51308
@targos
targos force-pushed the targos-patch-1 branch from dbeeca6 to 18d42f0 Compare May 3, 2024 12:25
richardlau
richardlau approved these changes May 3, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 3, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5956/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 3, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5956/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 3, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5956/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daeyeon
daeyeon approved these changes May 3, 2024
View reviewed changes
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 3, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5958/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 4, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 4, 2024
@nodejs-github-bot

nodejs-github-bot commented May 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58913/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes May 4, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58930/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes May 4, 2024
View reviewed changes
@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label May 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 5, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 54f1e0a into nodejs:main May 5, 2024
@nodejs-github-bot

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

Landed in 54f1e0a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos deleted the targos-patch-1 branch May 5, 2024 12:27
@targos targos mentioned this pull request May 6, 2024
Broken test/v8-updates/test-linux-perf-logger #51308
Closed
lukealbao added a commit to lukealbao/node that referenced this pull request May 7, 2024
@lukealbao
test: unskip v8-updates/test-linux-perf-logger
cdc89d0 
Refs: nodejs#51308 nodejs#52821
@lukealbao lukealbao mentioned this pull request May 7, 2024
test: unskip v8-updates/test-linux-perf-logger #52869
Closed
targos added a commit that referenced this pull request May 8, 2024
@targos
test: skip v8-updates/test-linux-perf-logger
1448959 
Refs: #51308
PR-URL: #52821
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
richardlau pushed a commit that referenced this pull request May 29, 2024
@lukealbao @richardlau
test: unskip v8-updates/test-linux-perf-logger
f671dcb 
Refs: #51308
Refs: #52821
PR-URL: #52869
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
targos pushed a commit that referenced this pull request Jun 1, 2024
@lukealbao @targos
test: unskip v8-updates/test-linux-perf-logger
c1138db 
Refs: #51308
Refs: #52821
PR-URL: #52869
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@targos @marco-ippolito
test: skip v8-updates/test-linux-perf-logger
0addeb2 
Refs: #51308
PR-URL: #52821
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@targos @soophoo
test: skip v8-updates/test-linux-perf-logger
340f434 
Refs: nodejs#51308
PR-URL: nodejs#52821
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@lukealbao @soophoo
test: unskip v8-updates/test-linux-perf-logger
5a80813 
Refs: nodejs#51308
Refs: nodejs#52821
PR-URL: nodejs#52869
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@SanchezDorso SanchezDorso mentioned this pull request May 13, 2026
test: v8-updates/test-linux-perf-logger fails on loongarch64 - RegExp JIT perf map entries not generated #63279
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@daeyeon daeyeon daeyeon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@targos @nodejs-github-bot @jasnell @lpinca @richardlau @daeyeon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.