GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: fix V8 update workflow by aduh95 · Pull Request #52822 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented May 3, 2024 •
edited by targos
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

IIUC the workflow is currently failing when an update is available because grep "V8 is up-to-date" returns a non-zero exit code. I tested locally, and can confirm it does fix the script.

Fixes: #50497

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
tools: fix V8 update workflow
603f07d
@aduh95
aduh95 requested a review from targos May 3, 2024 13:15
@nodejs-github-bot

nodejs-github-bot commented May 3, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 3, 2024
targos
targos reviewed May 3, 2024
View reviewed changes
Comment thread tools/dep_updaters/update-v8-patch.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 @targos
oops
ad36176 
Co-authored-by: Michaël Zasso <[email protected]>
targos
targos approved these changes May 3, 2024
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 3, 2024
marco-ippolito
marco-ippolito approved these changes May 3, 2024
View reviewed changes
@richardlau richardlau added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label May 3, 2024
richardlau
richardlau approved these changes May 3, 2024
View reviewed changes
jasnell
jasnell approved these changes May 4, 2024
View reviewed changes
lpinca
lpinca approved these changes May 4, 2024
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 5, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 38ef4e5 into nodejs:main May 5, 2024
@nodejs-github-bot

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

Landed in 38ef4e5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos mentioned this pull request May 5, 2024
V8 patch update workflow is broken #50497
Closed
targos pushed a commit that referenced this pull request May 8, 2024
@aduh95 @targos
tools: fix V8 update workflow
317998a 
PR-URL: #52822
Fixes: #50497
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@aduh95 @marco-ippolito
tools: fix V8 update workflow
b83fbf8 
PR-URL: #52822
Fixes: #50497
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@aduh95 @soophoo
tools: fix V8 update workflow
04456ce 
PR-URL: nodejs#52822
Fixes: nodejs#50497
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

V8 patch update workflow is broken

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@aduh95 @nodejs-github-bot @jasnell @lpinca @targos @richardlau @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.