GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update gyp-next to 0.18.0 by nodejs-github-bot · Pull Request #52835 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented May 5, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

This is an automated update of gyp-next to 0.18.0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot
tools: update gyp-next to 0.17.0
0ab35c3
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 5, 2024
@nodejs-github-bot

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/gyp
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. gyp Issues and PRs related to GYP and .gyp or .gypi build files. needs-ci PRs that need a full CI run. labels May 5, 2024
lpinca
lpinca approved these changes May 5, 2024
View reviewed changes
cclauss
cclauss requested changes May 5, 2024
View reviewed changes

@cclauss cclauss left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • nodejs/gyp-next#249

These two commands fail on Python 3.12 with ModuleNotFoundError: No module named 'packaging'
% pipx run --spec git+https://github.com/nodejs/gyp-next.git gyp --help
% pipx run --spec git+https://github.com/nodejs/gyp-next.git gyp --version

This was fixed in the past by:

  • nodejs/gyp-next#214

Also discussed in:

  • nodejs/gyp-next#247

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot
tools: update gyp-next to 0.18.0
d26f162
@nodejs-github-bot nodejs-github-bot changed the title tools: update gyp-next to 0.17.0 tools: update gyp-next to 0.18.0 May 9, 2024
cclauss
cclauss approved these changes May 9, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 9, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59053/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes May 9, 2024
View reviewed changes
@targos targos added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label May 9, 2024
@cclauss

cclauss commented May 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Should we wait on this fix for gyp --version on Python >= 3.12?

  • chore: dependencies = setuptools for gyp --version on Python >= 3.12 gyp-next#256
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cclauss
cclauss self-requested a review May 9, 2024 14:20
@targos

targos commented May 9, 2024

Copy link
Copy Markdown
Member

I'd say no because it doesn't matter for the usage in this project
cclauss and legendecas reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 9, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59060/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cclauss
cclauss approved these changes May 9, 2024
View reviewed changes
legendecas
legendecas approved these changes May 9, 2024
View reviewed changes
@legendecas legendecas added the commit-queue PRs queued for automated landing through the Commit Queue. label May 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 9, 2024
@nodejs-github-bot

nodejs-github-bot commented May 9, 2024

Copy link
Copy Markdown
Collaborator Author

Landed in 70995bd...a923fed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nodejs-github-bot added a commit that referenced this pull request May 9, 2024
@nodejs-github-bot
tools: update gyp-next to 0.17.0
62294f9 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
nodejs-github-bot added a commit that referenced this pull request May 9, 2024
@nodejs-github-bot
tools: update gyp-next to 0.18.0
a923fed 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@nodejs-github-bot nodejs-github-bot closed this May 9, 2024
@richardlau
richardlau deleted the actions/tools-update-gyp-next branch May 9, 2024 21:02
targos pushed a commit that referenced this pull request May 11, 2024
@nodejs-github-bot @targos
tools: update gyp-next to 0.17.0
c5f832a 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
targos pushed a commit that referenced this pull request May 11, 2024
@nodejs-github-bot @targos
tools: update gyp-next to 0.18.0
8ce23dc 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@mhdawson mhdawson mentioned this pull request May 13, 2024
Nightly builds broken on Linux nodejs/build#3718
Closed
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
@marco-ippolito marco-ippolito added the dont-land-on-v20.x label Jun 17, 2024
@marco-ippolito

marco-ippolito commented Jun 17, 2024

Copy link
Copy Markdown
Member

this breaks v20.x build https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian10-x64/58454/console
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cclauss

cclauss commented Jun 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test is running on Python 3.7 which is no longer supported:

Node.js configure: Found Python 3.7.3...
10:02:34 Traceback (most recent call last):
10:02:34   File "./configure", line 29, in <module>
10:02:34     import configure
10:02:34   File "/home/iojs/build/workspace/node-test-commit-linux/configure.py", line 30, in <module>
10:02:34     from gyp.common import GetFlavor
10:02:34   File "tools/gyp/pylib/gyp/__init__.py", line 9, in <module>
10:02:34     import gyp.input
10:02:34   File "tools/gyp/pylib/gyp/input.py", line 8, in <module>
10:02:34     import gyp.common
10:02:34   File "tools/gyp/pylib/gyp/common.py", line 435
10:02:34     if CC := os.environ.get("CC_target") or os.environ.get("CC"):
10:02:34            ^
10:02:34 SyntaxError: invalid syntax

Assignment expression https://docs.python.org/3/whatsnew/3.8.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@nodejs-github-bot @soophoo
tools: update gyp-next to 0.17.0
bc79a28 
PR-URL: nodejs#52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@nodejs-github-bot @soophoo
tools: update gyp-next to 0.18.0
37d5ba7 
PR-URL: nodejs#52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@cclauss cclauss cclauss approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. gyp Issues and PRs related to GYP and .gyp or .gypi build files. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@nodejs-github-bot @cclauss @targos @marco-ippolito @lpinca @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.