GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: specify a commit-message for V8 update workflow by aduh95 · Pull Request #52844 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented May 5, 2024

Copy link
Copy Markdown
Contributor

Fixes: #50497
Refs: gr2m/create-or-update-pull-request-action#280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
tools: specify a commit-message for V8 update workflow
ef28f94
@nodejs-github-bot

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 5, 2024
targos
targos approved these changes May 5, 2024
View reviewed changes
@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 5, 2024
@github-actions

github-actions Bot commented May 5, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.
richardlau and marco-ippolito reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes May 5, 2024
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 5, 2024
@nodejs-github-bot
nodejs-github-bot merged commit c6f8e18 into nodejs:main May 5, 2024
@nodejs-github-bot

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

Landed in c6f8e18
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented May 5, 2024

Copy link
Copy Markdown
Member

🫡
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the v8-auto-update branch May 5, 2024 14:13
targos pushed a commit that referenced this pull request May 8, 2024
@aduh95 @targos
tools: specify a commit-message for V8 update workflow
1ee38a5 
PR-URL: #52844
Fixes: #50497
Refs: gr2m/create-or-update-pull-request-action#280
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@aduh95 @marco-ippolito
tools: specify a commit-message for V8 update workflow
8f8fb91 
PR-URL: #52844
Fixes: #50497
Refs: gr2m/create-or-update-pull-request-action#280
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@aduh95 @soophoo
tools: specify a commit-message for V8 update workflow
eee57f9 
PR-URL: nodejs#52844
Fixes: nodejs#50497
Refs: gr2m/create-or-update-pull-request-action#280
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

V8 patch update workflow is broken

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @nodejs-github-bot @anonrig @targos @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.