GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update BUILDING.md previous versions links by targos · Pull Request #52852 · nodejs/node

Conversation

@targos

@targos targos commented May 6, 2024

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos
doc: update BUILDING.md previous versions links
3c4abb2
@targos targos added dont-land-on-v18.x labels May 6, 2024
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. labels May 6, 2024
richardlau
richardlau approved these changes May 6, 2024
View reviewed changes
UlisesGascon
UlisesGascon approved these changes May 6, 2024
View reviewed changes

@UlisesGascon UlisesGascon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes May 6, 2024
View reviewed changes
@targos targos added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 6, 2024
MoLow
MoLow approved these changes May 6, 2024
View reviewed changes
marco-ippolito
marco-ippolito approved these changes May 6, 2024
View reviewed changes
benjamingr
benjamingr approved these changes May 6, 2024
View reviewed changes
@benjamingr benjamingr added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 6, 2024
@github-actions

github-actions Bot commented May 6, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.
marco-ippolito and lpinca reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label May 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 6, 2024
@nodejs-github-bot
nodejs-github-bot merged commit b1b0233 into nodejs:main May 6, 2024
@nodejs-github-bot

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in b1b0233
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos deleted the update-previous branch May 6, 2024 12:31
targos added a commit that referenced this pull request May 8, 2024
@targos
doc: update BUILDING.md previous versions links
15aad62 
PR-URL: #52852
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@targos @soophoo
doc: update BUILDING.md previous versions links
ffc2d69 
PR-URL: nodejs#52852
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@richardlau richardlau richardlau approved these changes
@MoLow MoLow MoLow approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@targos @nodejs-github-bot @benjamingr @lpinca @UlisesGascon @richardlau @MoLow @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.