GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: avoid unused variable 'error' warning by targos · Pull Request #52886 · nodejs/node

Conversation

@targos

@targos targos commented May 8, 2024

Copy link
Copy Markdown
Member

The variable is only used in DEBUG mode. Define it only in that case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos
src: avoid unused variable 'error' warning
d99e53c 
The variable is only used in DEBUG mode. Define it only in that case.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the Node.js command-line debugger. needs-ci PRs that need a full CI run. labels May 8, 2024
MoLow
MoLow reviewed May 8, 2024
View reviewed changes
Comment thread src/debug_utils.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes May 8, 2024
View reviewed changes
@targos
fixup
f32fb36
@nodejs-github-bot

nodejs-github-bot commented May 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59032/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes May 8, 2024
View reviewed changes
lpinca
lpinca approved these changes May 8, 2024
View reviewed changes
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 9, 2024
benjamingr
benjamingr approved these changes May 9, 2024
View reviewed changes
@targos targos added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label May 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 10, 2024
@nodejs-github-bot
nodejs-github-bot merged commit e03529e into nodejs:main May 10, 2024
@nodejs-github-bot

nodejs-github-bot commented May 10, 2024

Copy link
Copy Markdown
Collaborator

Landed in e03529e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos deleted the debug_utils-warning branch May 10, 2024 08:09
targos added a commit that referenced this pull request May 11, 2024
@targos
src: avoid unused variable 'error' warning
c40a827 
The variable is only used in DEBUG mode. Define it only in that case.

PR-URL: #52886
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@targos @marco-ippolito
src: avoid unused variable 'error' warning
2dcbf18 
The variable is only used in DEBUG mode. Define it only in that case.

PR-URL: #52886
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@targos @soophoo
src: avoid unused variable 'error' warning
19ae489 
The variable is only used in DEBUG mode. Define it only in that case.

PR-URL: nodejs#52886
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. debugger Issues and PRs related to the Node.js command-line debugger. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@targos @nodejs-github-bot @benjamingr @lpinca @richardlau @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.